RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 03:48:13 +00:00
Code Issues Activity Actions

LibWeb: Clear circular download reference when download finished

Browse source
This commit is contained in:
Tom 2020-12-31 11:16:30 -07:00 • committed by Andreas Kling
parent 084c296362
commit a4b3eb6b2d
1 changed files with 4 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Libraries/LibWeb/Loader/ResourceLoader.cpp
View file

@ -184,7 +184,10 @@ void ResourceLoader::load(const LoadRequest& request, Function<void(ReadonlyByte
error_callback("HTTP load failed"); error_callback("HTTP load failed");
return; return;
} }
deferred_invoke([&](auto&) { const_cast<RefPtr<Protocol::Download>&>(download) = nullptr; }); deferred_invoke([download](auto&) {
// Clear circular reference of `download` captured by copy
const_cast<Protocol::Download&>(*download).on_buffered_download_finish = nullptr;
});
success_callback(payload, response_headers); success_callback(payload, response_headers);
}; };
download->set_should_buffer_all_input(true); download->set_should_buffer_all_input(true);