RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 22:27:44 +00:00
Code Issues Activity Actions

LibVideo: Rename Status -> State in PlaybackStatusChangeEvent class

Browse source 
A bit of a bikeshed, but status sounds more like a result of an action,
and state sounds more accurate to what the `PlaybackManager` does.

The previous and current state fields of the `PlaybackStateChangeEvent`
are now removed, since they were unused (for now).

This is a lead-up to the refactoring of VideoPlaybackManager to make
that diff more legible.
This commit is contained in:
Zaggy1024 2023-02-07 15:53:34 -06:00 • committed by Andreas Kling
parent 2ff11bac3d
commit a4c7672802
3 changed files with 7 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

17
Userland/Libraries/LibVideo/PlaybackManager.h
View file

@ -165,7 +165,7 @@ private:
enum EventType : unsigned {
DecoderErrorOccurred = (('v' << 2) | ('i' << 1) | 'd') << 4,
VideoFramePresent,
PlaybackStatusChange,
PlaybackStateChange,
};
class DecoderErrorEvent : public Core::Event {
@ -199,20 +199,13 @@ private:
RefPtr<Gfx::Bitmap> m_frame;
};
class PlaybackStatusChangeEvent : public Core::Event {
class PlaybackStateChangeEvent : public Core::Event {
public:
PlaybackStatusChangeEvent() = default;
explicit PlaybackStatusChangeEvent(PlaybackStatus status, PlaybackStatus previous_status)
: Core::Event(PlaybackStatusChange)
, m_status(status)
, m_previous_status(previous_status)
explicit PlaybackStateChangeEvent()
: Core::Event(PlaybackStateChange)
{
}
virtual ~PlaybackStatusChangeEvent() = default;
private:
PlaybackStatus m_status;
PlaybackStatus m_previous_status;
virtual ~PlaybackStateChangeEvent() = default;
};
inline StringView playback_status_to_string(PlaybackStatus status)