RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 06:37:44 +00:00
Code Issues Activity Actions

LibWeb: Make TreeWalker GC-allocated

Browse source
This commit is contained in:
Andreas Kling 2022-08-08 23:03:27 +02:00
parent bd629c45b5
commit a4ddb0ef87
7 changed files with 41 additions and 30 deletions
Download patch file Download diff file Expand all files Collapse all files

29
Userland/Libraries/LibWeb/DOM/TreeWalker.h
View file

@ -6,21 +6,21 @@
#pragma once
#include <AK/RefCounted.h>
#include <LibWeb/Bindings/Wrappable.h>
#include <LibWeb/DOM/NodeFilter.h>
namespace Web::DOM {
// https://dom.spec.whatwg.org/#treewalker
class TreeWalker
: public RefCounted<TreeWalker>
, public Bindings::Wrappable {
public:
using WrapperType = Bindings::TreeWalkerWrapper;
class TreeWalker final : public Bindings::PlatformObject {
JS_OBJECT(TreeWalker, JS::Object);
static NonnullRefPtr<TreeWalker> create(Node& root, unsigned what_to_show, NodeFilter*);
virtual ~TreeWalker() override = default;
public:
static JS::NonnullGCPtr<TreeWalker> create(Node& root, unsigned what_to_show, JS::GCPtr<NodeFilter>);
explicit TreeWalker(Node& root);
virtual ~TreeWalker() override;
TreeWalker& impl() { return *this; }
NonnullRefPtr<Node> current_node() const;
void set_current_node(Node&);
@ -35,12 +35,12 @@ public:
NonnullRefPtr<Node> root() { return m_root; }
NodeFilter* filter() { return m_filter.cell(); }
NodeFilter* filter() { return m_filter.ptr(); }
unsigned what_to_show() const { return m_what_to_show; }
private:
TreeWalker(Node& root);
virtual void visit_edges(Cell::Visitor&) override;
enum class ChildTraversalType {
First,
@ -66,10 +66,15 @@ private:
unsigned m_what_to_show { 0 };
// https://dom.spec.whatwg.org/#concept-traversal-filter
JS::Handle<DOM::NodeFilter> m_filter;
JS::GCPtr<DOM::NodeFilter> m_filter;
// https://dom.spec.whatwg.org/#concept-traversal-active
bool m_active { false };
};
}
namespace Web::Bindings {
inline JS::Object* wrap(JS::Realm&, Web::DOM::TreeWalker& object) { return &object; }
using TreeWalkerWrapper = Web::DOM::TreeWalker;
}