RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 19:37:35 +00:00
Code Issues Activity Actions

Tests/Kernel: Fix test after off-by-one fix in Memory::is_user_range()

Browse source 
Commit 890c647e0f fixed an off-by-one bug, so the mapping of the page
at the very end of the user address space now works correctly.

This change adjusts the test so cover the corner cases the original
version was designed too.validate.
This commit is contained in:
Brian Gianforcaro 2021-09-10 20:00:53 -07:00 • committed by Brian Gianforcaro
parent 890c647e0f
commit a4efaa7b47
1 changed files with 3 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

11
Tests/Kernel/TestEFault.cpp
View file

@ -85,15 +85,10 @@ TEST_CASE(test_efault)
// Test the page just below where the user VM ends.
jerk_page = (u8*)mmap((void*)(user_range_ceiling - PAGE_SIZE), PAGE_SIZE, PROT_READ | PROT_WRITE, MAP_ANONYMOUS | MAP_PRIVATE | MAP_FIXED, 0, 0);
EXPECT_EQ(jerk_page, MAP_FAILED);
EXPECT_EQ(errno, EFAULT);
EXPECT_EQ(jerk_page, (u8*)(user_range_ceiling - PAGE_SIZE));
// Test the page just before that
jerk_page = (u8*)mmap((void*)(user_range_ceiling - (2 * PAGE_SIZE)), PAGE_SIZE, PROT_READ | PROT_WRITE, MAP_ANONYMOUS | MAP_PRIVATE | MAP_FIXED, -1, 0);
EXPECT_EQ(jerk_page, (u8*)(user_range_ceiling - (2 * PAGE_SIZE)));
EXPECT_OK(read, jerk_page, 4096);
EXPECT_EFAULT(read, jerk_page, 4097);
EXPECT_OK(read, jerk_page, PAGE_SIZE);
EXPECT_EFAULT(read, jerk_page, PAGE_SIZE + 1);
// Test something that would wrap around the 2^32 mark.
EXPECT_EFAULT(read, jerk_page, 0x50000000);