RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-10 06:27:35 +00:00
Code Issues Activity Actions

LibJS: Add Object::define_accessor()

Browse source 
This is a helper function based on the getter/setter definition logic from
ObjectExpression::execute() to look up an Accessor property if it already
exists, define a new Accessor property if it doesn't exist, and set the getter or
setter function on the Accessor.
This commit is contained in:
Jack Karamanian 2020-06-13 21:23:33 -05:00 • committed by Andreas Kling
parent 949bffdc93
commit a535d58cac
3 changed files with 29 additions and 17 deletions
Download patch file Download diff file Expand all files Collapse all files

20
Libraries/LibJS/AST.cpp
View file

@ -1364,23 +1364,9 @@ Value ObjectExpression::execute(Interpreter& interpreter, GlobalObject& global_o
if (property.type() == ObjectProperty::Type::Getter || property.type() == ObjectProperty::Type::Setter) {
ASSERT(value.is_function());
Accessor* accessor { nullptr };
auto property_metadata = object->shape().lookup(key);
if (property_metadata.has_value()) {
auto existing_property = object->get_direct(property_metadata.value().offset);
if (existing_property.is_accessor())
accessor = &existing_property.as_accessor();
}
if (!accessor) {
accessor = Accessor::create(interpreter, global_object, nullptr, nullptr);
object->define_property(key, accessor, Attribute::Configurable | Attribute::Enumerable);
if (interpreter.exception())
return {};
}
if (property.type() == ObjectProperty::Type::Getter)
accessor->set_getter(&value.as_function());
else
accessor->set_setter(&value.as_function());
object->define_accessor(key, value.as_function(), property.type() == ObjectProperty::Type::Getter, Attribute::Configurable | Attribute::Enumerable);
if (interpreter.exception())
return {};
} else {
object->define_property(key, value);
if (interpreter.exception())