RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 08:27:45 +00:00
Code Issues Activity Actions

Shell: Hide job times behind SHELL_JOB_DEBUG flag

Browse source
This commit is contained in:
Andrew Kaster 2021-04-25 19:28:37 -06:00 • committed by Ali Mohammad Pur
parent 0d0f52337c
commit a5889b9aad
3 changed files with 12 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

4
AK/Debug.h.in
View file

@ -350,6 +350,10 @@
#cmakedefine01 SH_LANGUAGE_SERVER_DEBUG #cmakedefine01 SH_LANGUAGE_SERVER_DEBUG
#endif #endif
#ifndef SHELL_JOB_DEBUG
#cmakedefine01 SHELL_JOB_DEBUG
#endif
#ifndef SOLITAIRE_DEBUG #ifndef SOLITAIRE_DEBUG
#cmakedefine01 SOLITAIRE_DEBUG #cmakedefine01 SOLITAIRE_DEBUG
#endif #endif

1
Meta/CMake/all_the_debug_macros.cmake
View file

@ -57,6 +57,7 @@ set(CRYPTO_DEBUG ON)
set(DWARF_DEBUG ON) set(DWARF_DEBUG ON)
set(HUNKS_DEBUG ON) set(HUNKS_DEBUG ON)
set(JOB_DEBUG ON) set(JOB_DEBUG ON)
set(SHELL_JOB_DEBUG ON)
set(GIF_DEBUG ON) set(GIF_DEBUG ON)
set(JPG_DEBUG ON) set(JPG_DEBUG ON)
set(EMOJI_DEBUG ON) set(EMOJI_DEBUG ON)

18
Userland/Shell/Job.h
View file

@ -8,6 +8,7 @@
#include "Execution.h" #include "Execution.h"
#include "Forward.h" #include "Forward.h"
#include <AK/Debug.h>
#include <AK/Function.h> #include <AK/Function.h>
#include <AK/JsonObject.h> #include <AK/JsonObject.h>
#include <AK/JsonValue.h> #include <AK/JsonValue.h>
@ -16,11 +17,6 @@
#include <LibCore/ElapsedTimer.h> #include <LibCore/ElapsedTimer.h>
#include <LibCore/Object.h> #include <LibCore/Object.h>
#define JOB_TIME_INFO
#ifndef __serenity__
# undef JOB_TIME_INFO
#endif
namespace Shell { namespace Shell {
struct LocalFrame; struct LocalFrame;
@ -31,13 +27,13 @@ public:
~Job() ~Job()
{ {
#ifdef JOB_TIME_INFO if constexpr (SHELL_JOB_DEBUG) {
if (m_active) { if (m_active) {
auto elapsed = m_command_timer.elapsed(); auto elapsed = m_command_timer.elapsed();
// Don't mistake this for the command! // Don't mistake this for the command!
dbgln("Job entry '{}' deleted in {} ms", m_cmd, elapsed); dbgln("Job entry '{}' deleted in {} ms", m_cmd, elapsed);
}
} }
#endif
} }
Function<void(RefPtr<Job>)> on_exit; Function<void(RefPtr<Job>)> on_exit;