RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 16:47:36 +00:00
Code Issues Activity Actions

LibWeb+LibWebView: Show shadow roots in the DOM inspector

Browse source
This commit is contained in:
Simon Wanner 2023-03-18 00:19:25 +01:00 • committed by Andreas Kling
parent 482fa2d4e2
commit a5a3913e39
2 changed files with 15 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

16
Userland/Libraries/LibWeb/DOM/Node.cpp
View file

@ -1069,24 +1069,32 @@ void Node::serialize_tree_as_json(JsonObjectSerializer<StringBuilder>& object) c
} else if (is_comment()) { } else if (is_comment()) {
MUST(object.add("type"sv, "comment"sv)); MUST(object.add("type"sv, "comment"sv));
MUST(object.add("data"sv, static_cast<DOM::Comment const&>(*this).data())); MUST(object.add("data"sv, static_cast<DOM::Comment const&>(*this).data()));
} else if (is_shadow_root()) {
MUST(object.add("type"sv, "shadow-root"));
MUST(object.add("mode"sv, static_cast<DOM::ShadowRoot const&>(*this).mode() == Bindings::ShadowRootMode::Open ? "open"sv : "closed"sv));
} }
MUST((object.add("visible"sv, !!layout_node()))); MUST((object.add("visible"sv, !!layout_node())));
if (has_child_nodes()) { if (has_child_nodes() || (is_element() && static_cast<DOM::Element const*>(this)->is_shadow_host())) {
auto children = MUST(object.add_array("children"sv)); auto children = MUST(object.add_array("children"sv));
for_each_child([&children](DOM::Node& child) { auto add_child = [&children](DOM::Node const& child) {
if (child.is_uninteresting_whitespace_node()) if (child.is_uninteresting_whitespace_node())
return; return;
JsonObjectSerializer<StringBuilder> child_object = MUST(children.add_object()); JsonObjectSerializer<StringBuilder> child_object = MUST(children.add_object());
child.serialize_tree_as_json(child_object); child.serialize_tree_as_json(child_object);
MUST(child_object.finish()); MUST(child_object.finish());
}); };
for_each_child(add_child);
// Pseudo-elements don't have DOM nodes,so we have to add them separately.
if (is_element()) { if (is_element()) {
auto const* element = static_cast<DOM::Element const*>(this); auto const* element = static_cast<DOM::Element const*>(this);
// Pseudo-elements don't have DOM nodes,so we have to add them separately.
element->serialize_pseudo_elements_as_json(children); element->serialize_pseudo_elements_as_json(children);
if (element->is_shadow_host())
add_child(*element->shadow_root_internal());
} }
MUST(children.finish()); MUST(children.finish());

4
Userland/Libraries/LibWebView/DOMTreeModel.cpp
View file

@ -127,7 +127,7 @@ GUI::Variant DOMTreeModel::data(const GUI::ModelIndex& index, GUI::ModelRole rol
if (role == GUI::ModelRole::ForegroundColor) { if (role == GUI::ModelRole::ForegroundColor) {
// FIXME: Allow models to return a foreground color *role*. // FIXME: Allow models to return a foreground color *role*.
// Then we won't need to have a GUI::TreeView& member anymore. // Then we won't need to have a GUI::TreeView& member anymore.
if (type == "comment"sv) if (type == "comment"sv || type == "shadow-root"sv)
return m_tree_view->palette().syntax_comment(); return m_tree_view->palette().syntax_comment();
if (type == "pseudo-element"sv) if (type == "pseudo-element"sv)
return m_tree_view->palette().syntax_type(); return m_tree_view->palette().syntax_type();
@ -154,6 +154,8 @@ GUI::Variant DOMTreeModel::data(const GUI::ModelIndex& index, GUI::ModelRole rol
return with_whitespace_collapsed(node.get_deprecated_string("text"sv).value()); return with_whitespace_collapsed(node.get_deprecated_string("text"sv).value());
if (type == "comment"sv) if (type == "comment"sv)
return DeprecatedString::formatted("<!--{}-->", node.get_deprecated_string("data"sv).value()); return DeprecatedString::formatted("<!--{}-->", node.get_deprecated_string("data"sv).value());
if (type == "shadow-root"sv)
return DeprecatedString::formatted("{} ({})", node_name, node.get_deprecated_string("mode"sv).value());
if (type != "element") if (type != "element")
return node_name; return node_name;