From a5ad8b2959141c83a700651df9b3b992937f2549 Mon Sep 17 00:00:00 2001 From: Kenneth Myhra Date: Tue, 14 Feb 2023 21:02:46 +0100 Subject: [PATCH] LibWeb: Make factory method of DOM::AbortSignal fallible --- Userland/Libraries/LibWeb/DOM/AbortController.cpp | 2 +- Userland/Libraries/LibWeb/DOM/AbortSignal.cpp | 4 ++-- Userland/Libraries/LibWeb/DOM/AbortSignal.h | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/Userland/Libraries/LibWeb/DOM/AbortController.cpp b/Userland/Libraries/LibWeb/DOM/AbortController.cpp index 732f58d87d..63d4d47c47 100644 --- a/Userland/Libraries/LibWeb/DOM/AbortController.cpp +++ b/Userland/Libraries/LibWeb/DOM/AbortController.cpp @@ -12,7 +12,7 @@ namespace Web::DOM { WebIDL::ExceptionOr> AbortController::construct_impl(JS::Realm& realm) { - auto signal = AbortSignal::construct_impl(realm); + auto signal = TRY(AbortSignal::construct_impl(realm)); return MUST_OR_THROW_OOM(realm.heap().allocate(realm, realm, move(signal))); } diff --git a/Userland/Libraries/LibWeb/DOM/AbortSignal.cpp b/Userland/Libraries/LibWeb/DOM/AbortSignal.cpp index 5b1441f1d5..8277a3eea5 100644 --- a/Userland/Libraries/LibWeb/DOM/AbortSignal.cpp +++ b/Userland/Libraries/LibWeb/DOM/AbortSignal.cpp @@ -12,9 +12,9 @@ namespace Web::DOM { -JS::NonnullGCPtr AbortSignal::construct_impl(JS::Realm& realm) +WebIDL::ExceptionOr> AbortSignal::construct_impl(JS::Realm& realm) { - return realm.heap().allocate(realm, realm).release_allocated_value_but_fixme_should_propagate_errors(); + return MUST_OR_THROW_OOM(realm.heap().allocate(realm, realm)); } AbortSignal::AbortSignal(JS::Realm& realm) diff --git a/Userland/Libraries/LibWeb/DOM/AbortSignal.h b/Userland/Libraries/LibWeb/DOM/AbortSignal.h index 87552982c0..e0a6d7af55 100644 --- a/Userland/Libraries/LibWeb/DOM/AbortSignal.h +++ b/Userland/Libraries/LibWeb/DOM/AbortSignal.h @@ -18,7 +18,7 @@ class AbortSignal final : public EventTarget { WEB_PLATFORM_OBJECT(AbortSignal, EventTarget); public: - static JS::NonnullGCPtr construct_impl(JS::Realm&); + static WebIDL::ExceptionOr> construct_impl(JS::Realm&); virtual ~AbortSignal() override = default;