RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 12:17:35 +00:00
Code Issues Activity Actions

LibDebug: Store optional parent_offset in Dwarf::DIE objects

Browse source 
In the current implementation, only DIE objects that are created via
DIE::for_each_child() will have parent offsets.

DIE objects that are created with CompilationUnit::get_die_at_offset()
do not currently store a parent offset.

We may improve this in the future, but this is enough for what we
currently need.
This commit is contained in:
Itamar 2021-06-19 11:39:51 +03:00 • committed by Andreas Kling
parent 84609aecc1
commit a5f69efa5c
2 changed files with 9 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibDebug/Dwarf/DIE.h
View file

@ -1,5 +1,5 @@
/*
* Copyright (c) 2020, Itamar S. <itamar8910@gmail.com>
* Copyright (c) 2020-2021, Itamar S. <itamar8910@gmail.com>
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@ -33,6 +33,7 @@ public:
bool is_null() const { return m_tag == EntryTag::None; }
const CompilationUnit& compilation_unit() const { return m_compilation_unit; }
Optional<u32> parent_offset() const { return m_parent_offset; }
private:
const CompilationUnit& m_compilation_unit;
@ -42,6 +43,7 @@ private:
EntryTag m_tag { EntryTag::None };
bool m_has_children { false };
u32 m_size { 0 };
Optional<u32> m_parent_offset;
};
}