RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-28 05:37:44 +00:00
Code Issues Activity Actions

AK+Everywhere: Replace usages of URLParser::urlencode() and urldecode()

Browse source 
This replaces all occurrences of those functions with the newly
implemented functions URL::percent_encode() and URL::percent_decode().
The old functions will be removed in a further commit.
This commit is contained in:
Max Wipfli 2021-05-25 14:06:03 +02:00 • committed by Andreas Kling
parent 2a6c9bc5f7
commit a603e69599
5 changed files with 9 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

3
AK/URL.cpp
View file

@ -8,7 +8,6 @@
#include <AK/LexicalPath.h>
#include <AK/StringBuilder.h>
#include <AK/URL.h>
#include <AK/URLParser.h>
#include <AK/Utf8View.h>
namespace AK {
@ -237,7 +236,7 @@ bool URL::parse(const StringView& string)
if (state == State::InFragment)
m_fragment = String::copy(buffer);
if (state == State::InDataPayload)
m_data_payload = urldecode(String::copy(buffer));
m_data_payload = URL::percent_decode(String::copy(buffer));
if (state == State::InPort) {
auto port_opt = String::copy(buffer).to_uint();
if (port_opt.has_value())

4
AK/URL.h
View file

@ -9,7 +9,6 @@
#include <AK/String.h>
#include <AK/StringView.h>
#include <AK/URLParser.h>
namespace AK {
@ -62,8 +61,7 @@ public:
String to_string() const;
String to_string_encoded() const
{
// Exclusion character set is the same JS's encodeURI() uses
return urlencode(to_string(), "#$&+,/:;=?@");
return percent_encode(to_string(), PercentEncodeSet::EncodeURI);
}
URL complete_url(const String&) const;