1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 04:57:45 +00:00

Profiler: Use sequential serial numbers for profiling events

Previously Profiler was using timestamps to distinguish processes.
However it is possible that separate processes with the same PID exist
at the exact same timestamp (e.g. for execve). This changes Profiler
to use unique serial numbers for each event instead.
This commit is contained in:
Gunnar Beutner 2021-06-02 21:16:57 +02:00 committed by Linus Groh
parent af72b5ec82
commit a607f13fc7
8 changed files with 125 additions and 47 deletions

View file

@ -0,0 +1,70 @@
/*
* Copyright (c) 2021, Gunnar Beutner <gbeutner@serenityos.org>
*
* SPDX-License-Identifier: BSD-2-Clause
*/
#pragma once
#include <AK/Assertions.h>
#include <AK/NumericLimits.h>
#include <AK/Types.h>
namespace Profiler {
// DistinctNumeric's constructor is non-explicit which makes accidentally turning
// an unrelated u64 into a serial number all too easy.
class EventSerialNumber {
public:
constexpr EventSerialNumber() = default;
void increment()
{
m_serial++;
}
size_t to_number() const
{
return m_serial;
}
static EventSerialNumber max_valid_serial()
{
return EventSerialNumber { NumericLimits<size_t>::max() };
}
bool operator==(EventSerialNumber const& rhs) const
{
return m_serial == rhs.m_serial;
}
bool operator<(EventSerialNumber const& rhs) const
{
return m_serial < rhs.m_serial;
}
bool operator>(EventSerialNumber const& rhs) const
{
return m_serial > rhs.m_serial;
}
bool operator<=(EventSerialNumber const& rhs) const
{
return m_serial <= rhs.m_serial;
}
bool operator>=(EventSerialNumber const& rhs) const
{
return m_serial >= rhs.m_serial;
}
private:
size_t m_serial { 0 };
constexpr explicit EventSerialNumber(size_t serial)
: m_serial(serial)
{
}
};
}