RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 05:27:46 +00:00
Code Issues Activity Actions

LibJS: Be more lenient when parsing milliseconds for Date

Browse source 
Other engines don't give NaN if there is at least one digit after the
dot for milliseconds. We were much stricter and required exactly three
digits.
But there is real world usage of different amounts of digits such as
discord having three extra trailing zeros.
This commit is contained in:
davidot 2022-03-09 13:46:12 +01:00 • committed by Linus Groh
parent fd5eaf6494
commit a61424a62b
2 changed files with 53 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

26
Userland/Libraries/LibJS/Tests/builtins/Date/Date.parse.js
View file

@ -36,3 +36,29 @@ test("time clip", () => {
expect(Date.parse("+999999")).toBeNaN();
expect(Date.parse("-999999")).toBeNaN();
});
test("extra micro seconds extension", () => {
expect(Date.parse("2021-04-30T15:19:02.937+00:00")).toBe(1619795942937);
expect(Date.parse("2021-04-30T15:19:02.9370+00:00")).toBe(1619795942937);
expect(Date.parse("2021-04-30T15:19:02.93700+00:00")).toBe(1619795942937);
expect(Date.parse("2021-04-30T15:19:02.937000+00:00")).toBe(1619795942937);
expect(Date.parse("2021-04-30T15:19:02.93+00:00")).toBe(1619795942930);
expect(Date.parse("2021-04-30T15:19:02.9+00:00")).toBe(1619795942900);
// These values are just checked against NaN since they don't have a specified timezone.
expect(Date.parse("2021-04-30T15:19:02.93")).not.toBe(NaN);
expect(Date.parse("2021-04-30T15:19:02.9")).not.toBe(NaN);
expect(Date.parse("2021-04-30T15:19:02.+00:00")).toBe(NaN);
expect(Date.parse("2021-04-30T15:19:02.")).toBe(NaN);
expect(Date.parse("2021-04-30T15:19:02.a")).toBe(NaN);
expect(Date.parse("2021-04-30T15:19:02.000a")).toBe(NaN);
expect(Date.parse("2021-04-30T15:19:02.937001+00:00")).toBe(1619795942937);
expect(Date.parse("2021-04-30T15:19:02.937999+00:00")).toBe(1619795942937);
expect(Date.parse("2021-06-26T07:24:40.007000+00:00")).toBe(1624692280007);
expect(Date.parse("2021-06-26T07:24:40.0079999999999999999+00:00")).toBe(1624692280007);
expect(Date.parse("2021-04-15T18:47:25.606000+00:00")).toBe(1618512445606);
});