mirror of
https://github.com/RGBCube/serenity
synced 2025-07-25 13:27:35 +00:00
LibWeb: Implement window.open
This implementation is some-what complete, with the most common missing /broken feature being opening pages in new tabs using the "_blank" target. This is currently broken due to 2 reasons: - We currently always claim the Window does not have transient activation, as we do not track the transient activation timestamp yet. This means that all such window.open calls are detected as pop-ups, and as such they are blocked. This can be easily bypassed by unchecking the 'Block Pop-ups' checkbox in the debug menu. - There is currently no mechanism for the WebContent process to request a new tab to be created by the Browser process, and as such the call to BrowsingContext::choose_a_browsing_context does not actually open another tab.
This commit is contained in:
parent
d15d7636e5
commit
a63c7549e1
2 changed files with 151 additions and 0 deletions
|
@ -61,6 +61,7 @@ public:
|
|||
bool import_maps_allowed() const { return m_import_maps_allowed; }
|
||||
void set_import_maps_allowed(bool import_maps_allowed) { m_import_maps_allowed = import_maps_allowed; }
|
||||
|
||||
WebIDL::ExceptionOr<JS::GCPtr<HTML::WindowProxy>> open_impl(StringView url, StringView target, StringView features);
|
||||
void alert_impl(String const&);
|
||||
bool confirm_impl(String const&);
|
||||
String prompt_impl(String const&, String const&);
|
||||
|
@ -245,6 +246,7 @@ private:
|
|||
JS_DECLARE_NATIVE_FUNCTION(session_storage_getter);
|
||||
JS_DECLARE_NATIVE_FUNCTION(origin_getter);
|
||||
|
||||
JS_DECLARE_NATIVE_FUNCTION(open);
|
||||
JS_DECLARE_NATIVE_FUNCTION(alert);
|
||||
JS_DECLARE_NATIVE_FUNCTION(confirm);
|
||||
JS_DECLARE_NATIVE_FUNCTION(prompt);
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue