From a6917465d775c69dd18a922834cafd156df2cf7f Mon Sep 17 00:00:00 2001 From: Andreas Kling Date: Sun, 17 Jan 2021 21:32:59 +0100 Subject: [PATCH] Kernel: Assert on attempt to mark inode metadata dirty on read-only FS --- Kernel/FileSystem/Inode.cpp | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/Kernel/FileSystem/Inode.cpp b/Kernel/FileSystem/Inode.cpp index f74598ea41..7923c66f27 100644 --- a/Kernel/FileSystem/Inode.cpp +++ b/Kernel/FileSystem/Inode.cpp @@ -230,6 +230,12 @@ NonnullRefPtr Inode::fifo() void Inode::set_metadata_dirty(bool metadata_dirty) { LOCKER(m_lock); + + if (metadata_dirty) { + // Sanity check. + ASSERT(!fs().is_readonly()); + } + if (m_metadata_dirty == metadata_dirty) return;