diff --git a/Userland/Applets/ClipboardHistory/main.cpp b/Userland/Applets/ClipboardHistory/main.cpp index b8bdead8b2..ed0163ea37 100644 --- a/Userland/Applets/ClipboardHistory/main.cpp +++ b/Userland/Applets/ClipboardHistory/main.cpp @@ -84,7 +84,7 @@ ErrorOr serenity_main(Main::Arguments arguments) GUI::Clipboard::the().clear(); }); - auto entry_context_menu = TRY(GUI::Menu::try_create()); + auto entry_context_menu = GUI::Menu::construct(); entry_context_menu->add_action(delete_action); entry_context_menu->add_action(debug_dump_action); entry_context_menu->add_separator(); diff --git a/Userland/Applications/AnalogClock/main.cpp b/Userland/Applications/AnalogClock/main.cpp index 0efe3f3cb3..90483fc549 100644 --- a/Userland/Applications/AnalogClock/main.cpp +++ b/Userland/Applications/AnalogClock/main.cpp @@ -37,7 +37,7 @@ ErrorOr serenity_main(Main::Arguments arguments) clock->set_show_window_frame(action.is_checked()); }); show_window_frame_action->set_checked(clock->show_window_frame()); - auto menu = TRY(GUI::Menu::try_create()); + auto menu = GUI::Menu::construct(); menu->add_action(*show_window_frame_action); clock->on_context_menu_request = [&](auto& event) { diff --git a/Userland/Applications/BrowserSettings/AutoplaySettingsWidget.cpp b/Userland/Applications/BrowserSettings/AutoplaySettingsWidget.cpp index af273dd86d..d22a1f6e0c 100644 --- a/Userland/Applications/BrowserSettings/AutoplaySettingsWidget.cpp +++ b/Userland/Applications/BrowserSettings/AutoplaySettingsWidget.cpp @@ -65,7 +65,7 @@ ErrorOr> AutoplaySettingsWidget::create() widget->set_modified(true); } }); - widget->m_entry_context_menu = TRY(GUI::Menu::try_create()); + widget->m_entry_context_menu = GUI::Menu::construct(); widget->m_entry_context_menu->add_action(move(delete_action)); return widget; diff --git a/Userland/Applications/CalendarSettings/CalendarSettingsWidget.cpp b/Userland/Applications/CalendarSettings/CalendarSettingsWidget.cpp index ffb89956ae..872daacdf8 100644 --- a/Userland/Applications/CalendarSettings/CalendarSettingsWidget.cpp +++ b/Userland/Applications/CalendarSettings/CalendarSettingsWidget.cpp @@ -43,7 +43,7 @@ ErrorOr CalendarSettingsWidget::setup() m_first_day_of_week_combobox = *find_descendant_of_type_named("first_day_of_week"); m_first_day_of_week_combobox->set_text(Config::read_string("Calendar"sv, "View"sv, "FirstDayOfWeek"sv, "Sunday"sv)); m_first_day_of_week_combobox->set_only_allow_values_from_model(true); - m_first_day_of_week_combobox->set_model(*TRY((GUI::ItemListModel>::try_create(AK::long_day_names)))); + m_first_day_of_week_combobox->set_model(GUI::ItemListModel>::create(AK::long_day_names)); m_first_day_of_week_combobox->on_change = [&](auto, auto) { set_modified(true); }; @@ -51,7 +51,7 @@ ErrorOr CalendarSettingsWidget::setup() m_first_day_of_weekend_combobox = *find_descendant_of_type_named("first_day_of_weekend"); m_first_day_of_weekend_combobox->set_text(Config::read_string("Calendar"sv, "View"sv, "FirstDayOfWeekend"sv, "Saturday"sv)); m_first_day_of_weekend_combobox->set_only_allow_values_from_model(true); - m_first_day_of_weekend_combobox->set_model(*TRY((GUI::ItemListModel>::try_create(AK::long_day_names)))); + m_first_day_of_weekend_combobox->set_model(GUI::ItemListModel>::create(AK::long_day_names)); m_first_day_of_weekend_combobox->on_change = [&](auto, auto) { set_modified(true); }; @@ -65,7 +65,7 @@ ErrorOr CalendarSettingsWidget::setup() m_default_view_combobox = *find_descendant_of_type_named("default_view"); m_default_view_combobox->set_text(Config::read_string("Calendar"sv, "View"sv, "DefaultView"sv, "Month"sv)); m_default_view_combobox->set_only_allow_values_from_model(true); - m_default_view_combobox->set_model(*TRY((GUI::ItemListModel>::try_create(m_view_modes)))); + m_default_view_combobox->set_model(GUI::ItemListModel>::create(m_view_modes)); m_default_view_combobox->on_change = [&](auto, auto) { set_modified(true); }; diff --git a/Userland/Applications/FileManager/main.cpp b/Userland/Applications/FileManager/main.cpp index 94726b2782..0d799a499b 100644 --- a/Userland/Applications/FileManager/main.cpp +++ b/Userland/Applications/FileManager/main.cpp @@ -476,7 +476,7 @@ ErrorOr run_in_desktop_mode() paste_action->set_enabled(data_type == "text/uri-list" && access(directory_view->path().characters(), W_OK) == 0); }; - auto desktop_view_context_menu = TRY(GUI::Menu::try_create("Directory View"_string)); + auto desktop_view_context_menu = GUI::Menu::construct("Directory View"_string); auto file_manager_action = GUI::Action::create("Open in File &Manager", {}, TRY(Gfx::Bitmap::load_from_file("/res/icons/16x16/app-file-manager.png"sv)), [&](auto&) { auto paths = directory_view->selected_file_paths(); @@ -518,7 +518,7 @@ ErrorOr run_in_desktop_mode() desktop_view_context_menu->add_separator(); desktop_view_context_menu->add_action(display_properties_action); - auto desktop_context_menu = TRY(GUI::Menu::try_create("Directory View Directory"_string)); + auto desktop_context_menu = GUI::Menu::construct("Directory View Directory"_string); desktop_context_menu->add_action(file_manager_action); desktop_context_menu->add_action(open_terminal_action); @@ -679,9 +679,9 @@ ErrorOr run_in_windowed_mode(DeprecatedString const& initial_location, Depr directory_view->refresh(); }; - auto directory_context_menu = TRY(GUI::Menu::try_create("Directory View Directory"_string)); - auto directory_view_context_menu = TRY(GUI::Menu::try_create("Directory View"_string)); - auto tree_view_directory_context_menu = TRY(GUI::Menu::try_create("Tree View Directory"_string)); + auto directory_context_menu = GUI::Menu::construct("Directory View Directory"_string); + auto directory_view_context_menu = GUI::Menu::construct("Directory View"_string); + auto tree_view_directory_context_menu = GUI::Menu::construct("Tree View Directory"_string); auto open_parent_directory_action = GUI::Action::create("Open &Parent Directory", { Mod_Alt, Key_Up }, TRY(Gfx::Bitmap::load_from_file("/res/icons/16x16/open-parent-directory.png"sv)), [&](GUI::Action const&) { directory_view->open_parent_directory(); diff --git a/Userland/Applications/FontEditor/MainWidget.cpp b/Userland/Applications/FontEditor/MainWidget.cpp index 925b8695bd..a9895c52f9 100644 --- a/Userland/Applications/FontEditor/MainWidget.cpp +++ b/Userland/Applications/FontEditor/MainWidget.cpp @@ -414,12 +414,12 @@ ErrorOr MainWidget::create_models() TRY(m_font_slope_list.try_ensure_capacity(Gfx::font_slope_names.size())); for (auto& it : Gfx::font_slope_names) m_font_slope_list.unchecked_append(TRY(String::from_utf8(it.name))); - m_slope_combobox->set_model(TRY(GUI::ItemListModel::try_create(m_font_slope_list))); + m_slope_combobox->set_model(GUI::ItemListModel::create(m_font_slope_list)); TRY(m_font_weight_list.try_ensure_capacity(Gfx::font_weight_names.size())); for (auto& it : Gfx::font_weight_names) m_font_weight_list.unchecked_append(TRY(String::from_utf8(it.name))); - m_weight_combobox->set_model(TRY(GUI::ItemListModel::try_create(m_font_weight_list))); + m_weight_combobox->set_model(GUI::ItemListModel::create(m_font_weight_list)); auto unicode_blocks = Unicode::block_display_names(); TRY(m_unicode_block_list.try_ensure_capacity(unicode_blocks.size() + 1)); @@ -427,7 +427,7 @@ ErrorOr MainWidget::create_models() for (auto& block : unicode_blocks) m_unicode_block_list.unchecked_append(TRY(String::from_utf8(block.display_name))); - m_unicode_block_model = TRY(GUI::ItemListModel::try_create(m_unicode_block_list)); + m_unicode_block_model = GUI::ItemListModel::create(m_unicode_block_list); m_filter_model = TRY(GUI::FilteringProxyModel::create(*m_unicode_block_model)); m_filter_model->set_filter_term(""sv); diff --git a/Userland/Applications/FontEditor/NewFontDialog.cpp b/Userland/Applications/FontEditor/NewFontDialog.cpp index 3c849ccc2c..ef8a0255d8 100644 --- a/Userland/Applications/FontEditor/NewFontDialog.cpp +++ b/Userland/Applications/FontEditor/NewFontDialog.cpp @@ -145,13 +145,13 @@ ErrorOr NewFontDialog::build() TRY(m_font_weight_list.try_ensure_capacity(Gfx::font_weight_names.size())); for (auto& it : Gfx::font_weight_names) m_font_weight_list.unchecked_append(TRY(String::from_utf8(it.name))); - m_weight_combobox->set_model(TRY(GUI::ItemListModel::try_create(m_font_weight_list))); + m_weight_combobox->set_model(GUI::ItemListModel::create(m_font_weight_list)); m_weight_combobox->set_selected_index(3); TRY(m_font_slope_list.try_ensure_capacity(Gfx::font_slope_names.size())); for (auto& it : Gfx::font_slope_names) m_font_slope_list.unchecked_append(TRY(String::from_utf8(it.name))); - m_slope_combobox->set_model(TRY(GUI::ItemListModel::try_create(m_font_slope_list))); + m_slope_combobox->set_model(GUI::ItemListModel::create(m_font_slope_list)); m_slope_combobox->set_selected_index(0); m_presentation_spinbox->set_value(12); diff --git a/Userland/Applications/Help/MainWidget.cpp b/Userland/Applications/Help/MainWidget.cpp index b09350e875..2443ec0834 100644 --- a/Userland/Applications/Help/MainWidget.cpp +++ b/Userland/Applications/Help/MainWidget.cpp @@ -223,7 +223,7 @@ ErrorOr MainWidget::initialize_fallibles(GUI::Window& window) })); help_menu->add_action(GUI::CommonActions::make_about_action("Help"_string, TRY(GUI::Icon::try_create_default_icon("app-help"sv)), &window)); - m_context_menu = TRY(GUI::Menu::try_create()); + m_context_menu = GUI::Menu::construct(); m_context_menu->add_action(*m_go_back_action); m_context_menu->add_action(*m_go_forward_action); m_context_menu->add_action(*m_go_home_action); diff --git a/Userland/Applications/MailSettings/MailSettingsWidget.cpp b/Userland/Applications/MailSettings/MailSettingsWidget.cpp index 5229d2484c..37bb033cd7 100644 --- a/Userland/Applications/MailSettings/MailSettingsWidget.cpp +++ b/Userland/Applications/MailSettings/MailSettingsWidget.cpp @@ -60,7 +60,7 @@ ErrorOr MailSettingsWidget::setup() m_port_combobox = *find_descendant_of_type_named("port_input"); m_port_combobox->set_text(Config::read_string("Mail"sv, "Connection"sv, "Port"sv, "993"sv)); m_port_combobox->set_only_allow_values_from_model(false); - m_port_combobox->set_model(*TRY(GUI::ItemListModel::try_create(m_common_ports))); + m_port_combobox->set_model(*GUI::ItemListModel::create(m_common_ports)); m_port_combobox->on_change = [&](auto, auto) { set_modified(true); }; diff --git a/Userland/Applications/NetworkSettings/NetworkSettingsWidget.cpp b/Userland/Applications/NetworkSettings/NetworkSettingsWidget.cpp index 91acb0bc55..da47f1035d 100644 --- a/Userland/Applications/NetworkSettings/NetworkSettingsWidget.cpp +++ b/Userland/Applications/NetworkSettings/NetworkSettingsWidget.cpp @@ -109,7 +109,7 @@ ErrorOr NetworkSettingsWidget::setup() ::exit(1); } - m_adapters_combobox->set_model(TRY(GUI::ItemListModel::try_create(m_adapter_names))); + m_adapters_combobox->set_model(GUI::ItemListModel::create(m_adapter_names)); m_adapters_combobox->on_change = [this](DeprecatedString const& text, GUI::ModelIndex const&) { on_switch_adapter(text); }; diff --git a/Userland/Applications/PixelPaint/FilterGallery.cpp b/Userland/Applications/PixelPaint/FilterGallery.cpp index 3920dab3b2..cc2cad9cd2 100644 --- a/Userland/Applications/PixelPaint/FilterGallery.cpp +++ b/Userland/Applications/PixelPaint/FilterGallery.cpp @@ -36,7 +36,7 @@ FilterGallery::FilterGallery(GUI::Window* parent_window, ImageEditor* editor) VERIFY(m_config_widget); VERIFY(m_preview_widget); - m_error_label = GUI::Label::try_create().release_value_but_fixme_should_propagate_errors(); + m_error_label = GUI::Label::construct(); m_error_label->set_enabled(false); auto filter_tree_model = MUST(create_filter_tree_model(editor)); diff --git a/Userland/Applications/PixelPaint/Filters/Bloom.cpp b/Userland/Applications/PixelPaint/Filters/Bloom.cpp index 7725d07d86..136c7c97ce 100644 --- a/Userland/Applications/PixelPaint/Filters/Bloom.cpp +++ b/Userland/Applications/PixelPaint/Filters/Bloom.cpp @@ -37,7 +37,7 @@ void Bloom::apply(Gfx::Bitmap& target_bitmap) const ErrorOr> Bloom::get_settings_widget() { if (!m_settings_widget) { - auto settings_widget = TRY(GUI::Widget::try_create()); + auto settings_widget = GUI::Widget::construct(); settings_widget->set_layout(); auto name_label = TRY(settings_widget->try_add("Bloom Filter"_string)); diff --git a/Userland/Applications/PixelPaint/Filters/FastBoxBlur.cpp b/Userland/Applications/PixelPaint/Filters/FastBoxBlur.cpp index 5c7299dd44..f29a48199b 100644 --- a/Userland/Applications/PixelPaint/Filters/FastBoxBlur.cpp +++ b/Userland/Applications/PixelPaint/Filters/FastBoxBlur.cpp @@ -39,7 +39,7 @@ void FastBoxBlur::apply(Gfx::Bitmap& target_bitmap) const ErrorOr> FastBoxBlur::get_settings_widget() { if (!m_settings_widget) { - auto settings_widget = TRY(GUI::Widget::try_create()); + auto settings_widget = GUI::Widget::construct(); settings_widget->set_layout(); auto name_label = TRY(settings_widget->try_add("Fast Box Blur Filter"_string)); diff --git a/Userland/Applications/PixelPaint/Filters/Filter.cpp b/Userland/Applications/PixelPaint/Filters/Filter.cpp index f766e50e78..97c0572086 100644 --- a/Userland/Applications/PixelPaint/Filters/Filter.cpp +++ b/Userland/Applications/PixelPaint/Filters/Filter.cpp @@ -25,7 +25,7 @@ Filter::Filter(ImageEditor* editor) ErrorOr> Filter::get_settings_widget() { if (!m_settings_widget) { - auto settings_widget = TRY(GUI::Widget::try_create()); + auto settings_widget = GUI::Widget::construct(); settings_widget->set_layout(); auto name_label = TRY(settings_widget->try_add(TRY(String::from_utf8(filter_name())))); diff --git a/Userland/Applications/PixelPaint/Filters/HueAndSaturation.cpp b/Userland/Applications/PixelPaint/Filters/HueAndSaturation.cpp index e4b6231ded..c14490a3b0 100644 --- a/Userland/Applications/PixelPaint/Filters/HueAndSaturation.cpp +++ b/Userland/Applications/PixelPaint/Filters/HueAndSaturation.cpp @@ -30,7 +30,7 @@ void HueAndSaturation::apply(Gfx::Bitmap& target_bitmap) const ErrorOr> HueAndSaturation::get_settings_widget() { if (!m_settings_widget) { - auto settings_widget = TRY(GUI::Widget::try_create()); + auto settings_widget = GUI::Widget::construct(); settings_widget->set_layout(); auto add_slider = [&](auto name, int min, int max, auto member) -> ErrorOr { diff --git a/Userland/Applications/PixelPaint/Filters/Median.cpp b/Userland/Applications/PixelPaint/Filters/Median.cpp index 25737a3c02..2b2db94f97 100644 --- a/Userland/Applications/PixelPaint/Filters/Median.cpp +++ b/Userland/Applications/PixelPaint/Filters/Median.cpp @@ -45,7 +45,7 @@ void Median::apply(Gfx::Bitmap& target_bitmap, Gfx::Bitmap const& source_bitmap) ErrorOr> Median::get_settings_widget() { if (!m_settings_widget) { - auto settings_widget = TRY(GUI::Widget::try_create()); + auto settings_widget = GUI::Widget::construct(); TRY(settings_widget->load_from_gml(median_settings_gml)); settings_widget->find_descendant_of_type_named("filter_radius")->on_change = [this](auto value) { m_filter_radius = value; diff --git a/Userland/Applications/PixelPaint/Filters/Sepia.cpp b/Userland/Applications/PixelPaint/Filters/Sepia.cpp index a77e14d2ff..d8c7771408 100644 --- a/Userland/Applications/PixelPaint/Filters/Sepia.cpp +++ b/Userland/Applications/PixelPaint/Filters/Sepia.cpp @@ -20,7 +20,7 @@ void Sepia::apply(Gfx::Bitmap& target_bitmap, Gfx::Bitmap const& source_bitmap) ErrorOr> Sepia::get_settings_widget() { if (!m_settings_widget) { - auto settings_widget = TRY(GUI::Widget::try_create()); + auto settings_widget = GUI::Widget::construct(); settings_widget->set_layout(); auto name_label = TRY(settings_widget->try_add("Sepia Filter"_string)); diff --git a/Userland/Applications/PixelPaint/MainWidget.cpp b/Userland/Applications/PixelPaint/MainWidget.cpp index ce2b7057ec..7effaf89db 100644 --- a/Userland/Applications/PixelPaint/MainWidget.cpp +++ b/Userland/Applications/PixelPaint/MainWidget.cpp @@ -564,13 +564,13 @@ ErrorOr MainWidget::initialize_menubar(GUI::Window& window) show_pixel_grid_action->set_checked(Config::read_bool("PixelPaint"sv, "PixelGrid"sv, "Show"sv, true)); m_view_menu->add_action(*show_pixel_grid_action); - m_show_rulers_action = TRY(GUI::Action::try_create_checkable( + m_show_rulers_action = GUI::Action::create_checkable( "Show R&ulers", { Mod_Ctrl, Key_R }, [&](auto& action) { Config::write_bool("PixelPaint"sv, "Rulers"sv, "Show"sv, action.is_checked()); auto* editor = current_image_editor(); VERIFY(editor); editor->set_ruler_visibility(action.is_checked()); - })); + }); m_show_rulers_action->set_checked(Config::read_bool("PixelPaint"sv, "Rulers"sv, "Show"sv, true)); m_view_menu->add_action(*m_show_rulers_action); diff --git a/Userland/Applications/PixelPaint/Tools/BrushTool.cpp b/Userland/Applications/PixelPaint/Tools/BrushTool.cpp index 228ad96532..ea658cad63 100644 --- a/Userland/Applications/PixelPaint/Tools/BrushTool.cpp +++ b/Userland/Applications/PixelPaint/Tools/BrushTool.cpp @@ -200,7 +200,7 @@ void BrushTool::draw_line(Gfx::Bitmap& bitmap, Gfx::Color color, Gfx::IntPoint s ErrorOr BrushTool::get_properties_widget() { if (!m_properties_widget) { - auto properties_widget = TRY(GUI::Widget::try_create()); + auto properties_widget = GUI::Widget::construct(); properties_widget->set_layout(); auto mode_container = TRY(properties_widget->try_add()); diff --git a/Userland/Applications/PixelPaint/Tools/BucketTool.cpp b/Userland/Applications/PixelPaint/Tools/BucketTool.cpp index 491cbff7f8..a4da2e9736 100644 --- a/Userland/Applications/PixelPaint/Tools/BucketTool.cpp +++ b/Userland/Applications/PixelPaint/Tools/BucketTool.cpp @@ -64,7 +64,7 @@ void BucketTool::on_mousedown(Layer* layer, MouseEvent& event) ErrorOr BucketTool::get_properties_widget() { if (!m_properties_widget) { - auto properties_widget = TRY(GUI::Widget::try_create()); + auto properties_widget = GUI::Widget::construct(); properties_widget->set_layout(); auto threshold_container = TRY(properties_widget->try_add()); diff --git a/Userland/Applications/PixelPaint/Tools/CloneTool.cpp b/Userland/Applications/PixelPaint/Tools/CloneTool.cpp index 8c85c0094a..ee7f6280c8 100644 --- a/Userland/Applications/PixelPaint/Tools/CloneTool.cpp +++ b/Userland/Applications/PixelPaint/Tools/CloneTool.cpp @@ -128,7 +128,7 @@ void CloneTool::on_keyup(GUI::KeyEvent& event) ErrorOr CloneTool::get_properties_widget() { if (!m_properties_widget) { - auto properties_widget = TRY(GUI::Widget::try_create()); + auto properties_widget = GUI::Widget::construct(); properties_widget->set_layout(); auto size_container = TRY(properties_widget->try_add()); diff --git a/Userland/Applications/PixelPaint/Tools/EllipseTool.cpp b/Userland/Applications/PixelPaint/Tools/EllipseTool.cpp index f57047a585..957c2e2785 100644 --- a/Userland/Applications/PixelPaint/Tools/EllipseTool.cpp +++ b/Userland/Applications/PixelPaint/Tools/EllipseTool.cpp @@ -129,7 +129,7 @@ bool EllipseTool::on_keydown(GUI::KeyEvent& event) ErrorOr EllipseTool::get_properties_widget() { if (!m_properties_widget) { - auto properties_widget = TRY(GUI::Widget::try_create()); + auto properties_widget = GUI::Widget::construct(); properties_widget->set_layout(); auto thickness_container = TRY(properties_widget->try_add()); diff --git a/Userland/Applications/PixelPaint/Tools/EraseTool.cpp b/Userland/Applications/PixelPaint/Tools/EraseTool.cpp index 85b5a6c84d..e66b75c2d1 100644 --- a/Userland/Applications/PixelPaint/Tools/EraseTool.cpp +++ b/Userland/Applications/PixelPaint/Tools/EraseTool.cpp @@ -57,7 +57,7 @@ void EraseTool::draw_point(Gfx::Bitmap& bitmap, Gfx::Color color, Gfx::IntPoint ErrorOr EraseTool::get_properties_widget() { if (!m_properties_widget) { - auto properties_widget = TRY(GUI::Widget::try_create()); + auto properties_widget = GUI::Widget::construct(); properties_widget->set_layout(); auto size_container = TRY(properties_widget->try_add()); diff --git a/Userland/Applications/PixelPaint/Tools/GradientTool.cpp b/Userland/Applications/PixelPaint/Tools/GradientTool.cpp index fb3f9df804..8b4f6c1a22 100644 --- a/Userland/Applications/PixelPaint/Tools/GradientTool.cpp +++ b/Userland/Applications/PixelPaint/Tools/GradientTool.cpp @@ -201,7 +201,7 @@ void GradientTool::on_tool_activation() ErrorOr GradientTool::get_properties_widget() { if (!m_properties_widget) { - auto properties_widget = TRY(GUI::Widget::try_create()); + auto properties_widget = GUI::Widget::construct(); properties_widget->set_layout(); auto mode_container = TRY(properties_widget->try_add()); diff --git a/Userland/Applications/PixelPaint/Tools/GuideTool.cpp b/Userland/Applications/PixelPaint/Tools/GuideTool.cpp index 02fc159856..efce3a9340 100644 --- a/Userland/Applications/PixelPaint/Tools/GuideTool.cpp +++ b/Userland/Applications/PixelPaint/Tools/GuideTool.cpp @@ -179,7 +179,7 @@ void GuideTool::on_tool_activation() ErrorOr GuideTool::get_properties_widget() { if (!m_properties_widget) { - auto properties_widget = TRY(GUI::Widget::try_create()); + auto properties_widget = GUI::Widget::construct(); properties_widget->set_layout(); auto snapping_container = TRY(properties_widget->try_add()); diff --git a/Userland/Applications/PixelPaint/Tools/LassoSelectTool.cpp b/Userland/Applications/PixelPaint/Tools/LassoSelectTool.cpp index f4382b6074..45d86ea9a7 100644 --- a/Userland/Applications/PixelPaint/Tools/LassoSelectTool.cpp +++ b/Userland/Applications/PixelPaint/Tools/LassoSelectTool.cpp @@ -160,7 +160,7 @@ ErrorOr LassoSelectTool::get_properties_widget() return m_properties_widget.ptr(); } - auto properties_widget = TRY(GUI::Widget::try_create()); + auto properties_widget = GUI::Widget::construct(); properties_widget->set_layout(); auto mode_container = TRY(properties_widget->try_add()); diff --git a/Userland/Applications/PixelPaint/Tools/LineTool.cpp b/Userland/Applications/PixelPaint/Tools/LineTool.cpp index d41b150483..461c9a6162 100644 --- a/Userland/Applications/PixelPaint/Tools/LineTool.cpp +++ b/Userland/Applications/PixelPaint/Tools/LineTool.cpp @@ -122,7 +122,7 @@ bool LineTool::on_keydown(GUI::KeyEvent& event) ErrorOr LineTool::get_properties_widget() { if (!m_properties_widget) { - auto properties_widget = TRY(GUI::Widget::try_create()); + auto properties_widget = GUI::Widget::construct(); properties_widget->set_layout(); auto thickness_container = TRY(properties_widget->try_add()); diff --git a/Userland/Applications/PixelPaint/Tools/MoveTool.cpp b/Userland/Applications/PixelPaint/Tools/MoveTool.cpp index 8a20ea99cd..890a1bb6bb 100644 --- a/Userland/Applications/PixelPaint/Tools/MoveTool.cpp +++ b/Userland/Applications/PixelPaint/Tools/MoveTool.cpp @@ -292,7 +292,7 @@ Variant> MoveTool::cursor( ErrorOr MoveTool::get_properties_widget() { if (!m_properties_widget) { - auto properties_widget = TRY(GUI::Widget::try_create()); + auto properties_widget = GUI::Widget::construct(); properties_widget->set_layout(); auto selection_mode_container = TRY(properties_widget->try_add()); diff --git a/Userland/Applications/PixelPaint/Tools/PenTool.cpp b/Userland/Applications/PixelPaint/Tools/PenTool.cpp index 5d13c1904f..738940b6aa 100644 --- a/Userland/Applications/PixelPaint/Tools/PenTool.cpp +++ b/Userland/Applications/PixelPaint/Tools/PenTool.cpp @@ -38,7 +38,7 @@ void PenTool::draw_line(Gfx::Bitmap& bitmap, Gfx::Color color, Gfx::IntPoint sta ErrorOr PenTool::get_properties_widget() { if (!m_properties_widget) { - auto properties_widget = TRY(GUI::Widget::try_create()); + auto properties_widget = GUI::Widget::construct(); properties_widget->set_layout(); auto size_container = TRY(properties_widget->try_add()); diff --git a/Userland/Applications/PixelPaint/Tools/PickerTool.cpp b/Userland/Applications/PixelPaint/Tools/PickerTool.cpp index 4e34d79794..f51bf23f62 100644 --- a/Userland/Applications/PixelPaint/Tools/PickerTool.cpp +++ b/Userland/Applications/PixelPaint/Tools/PickerTool.cpp @@ -44,7 +44,7 @@ void PickerTool::on_mousemove(Layer* layer, MouseEvent& event) ErrorOr PickerTool::get_properties_widget() { if (!m_properties_widget) { - auto properties_widget = TRY(GUI::Widget::try_create()); + auto properties_widget = GUI::Widget::construct(); properties_widget->set_layout(); auto sample_checkbox = TRY(properties_widget->try_add("Sample all layers"_string)); diff --git a/Userland/Applications/PixelPaint/Tools/PolygonalSelectTool.cpp b/Userland/Applications/PixelPaint/Tools/PolygonalSelectTool.cpp index 2a55610d01..1690a006b9 100644 --- a/Userland/Applications/PixelPaint/Tools/PolygonalSelectTool.cpp +++ b/Userland/Applications/PixelPaint/Tools/PolygonalSelectTool.cpp @@ -189,7 +189,7 @@ ErrorOr PolygonalSelectTool::get_properties_widget() if (m_properties_widget) return m_properties_widget.ptr(); - auto properties_widget = TRY(GUI::Widget::try_create()); + auto properties_widget = GUI::Widget::construct(); properties_widget->set_layout(); auto mode_container = TRY(properties_widget->try_add()); diff --git a/Userland/Applications/PixelPaint/Tools/RectangleSelectTool.cpp b/Userland/Applications/PixelPaint/Tools/RectangleSelectTool.cpp index 14399d735a..2b775bb5ae 100644 --- a/Userland/Applications/PixelPaint/Tools/RectangleSelectTool.cpp +++ b/Userland/Applications/PixelPaint/Tools/RectangleSelectTool.cpp @@ -157,7 +157,7 @@ ErrorOr RectangleSelectTool::get_properties_widget() return m_properties_widget.ptr(); } - auto properties_widget = TRY(GUI::Widget::try_create()); + auto properties_widget = GUI::Widget::construct(); properties_widget->set_layout(); auto feather_container = TRY(properties_widget->try_add()); diff --git a/Userland/Applications/PixelPaint/Tools/RectangleTool.cpp b/Userland/Applications/PixelPaint/Tools/RectangleTool.cpp index e98307913a..09ee0741ae 100644 --- a/Userland/Applications/PixelPaint/Tools/RectangleTool.cpp +++ b/Userland/Applications/PixelPaint/Tools/RectangleTool.cpp @@ -143,7 +143,7 @@ bool RectangleTool::on_keydown(GUI::KeyEvent& event) ErrorOr RectangleTool::get_properties_widget() { if (!m_properties_widget) { - auto properties_widget = TRY(GUI::Widget::try_create()); + auto properties_widget = GUI::Widget::construct(); properties_widget->set_layout(); auto thickness_or_radius_container = TRY(properties_widget->try_add()); diff --git a/Userland/Applications/PixelPaint/Tools/SprayTool.cpp b/Userland/Applications/PixelPaint/Tools/SprayTool.cpp index 6d34acb104..410c0724b2 100644 --- a/Userland/Applications/PixelPaint/Tools/SprayTool.cpp +++ b/Userland/Applications/PixelPaint/Tools/SprayTool.cpp @@ -93,7 +93,7 @@ void SprayTool::on_mouseup(Layer*, MouseEvent&) ErrorOr SprayTool::get_properties_widget() { if (!m_properties_widget) { - auto properties_widget = TRY(GUI::Widget::try_create()); + auto properties_widget = GUI::Widget::construct(); properties_widget->set_layout(); auto size_container = TRY(properties_widget->try_add()); diff --git a/Userland/Applications/PixelPaint/Tools/TextTool.cpp b/Userland/Applications/PixelPaint/Tools/TextTool.cpp index 2759f5c16b..4b38b2e9b7 100644 --- a/Userland/Applications/PixelPaint/Tools/TextTool.cpp +++ b/Userland/Applications/PixelPaint/Tools/TextTool.cpp @@ -108,7 +108,7 @@ ErrorOr TextTool::get_properties_widget() if (m_properties_widget) return m_properties_widget.ptr(); - auto properties_widget = TRY(GUI::Widget::try_create()); + auto properties_widget = GUI::Widget::construct(); properties_widget->set_layout(); auto font_header = TRY(properties_widget->try_add("Current Font:"_string)); diff --git a/Userland/Applications/PixelPaint/Tools/WandSelectTool.cpp b/Userland/Applications/PixelPaint/Tools/WandSelectTool.cpp index d134202c2d..fb6a302b4b 100644 --- a/Userland/Applications/PixelPaint/Tools/WandSelectTool.cpp +++ b/Userland/Applications/PixelPaint/Tools/WandSelectTool.cpp @@ -72,7 +72,7 @@ ErrorOr WandSelectTool::get_properties_widget() return m_properties_widget.ptr(); } - auto properties_widget = TRY(GUI::Widget::try_create()); + auto properties_widget = GUI::Widget::construct(); properties_widget->set_layout(); auto threshold_container = TRY(properties_widget->try_add()); diff --git a/Userland/Applications/PixelPaint/Tools/ZoomTool.cpp b/Userland/Applications/PixelPaint/Tools/ZoomTool.cpp index 1327cf5dc1..5ec4506146 100644 --- a/Userland/Applications/PixelPaint/Tools/ZoomTool.cpp +++ b/Userland/Applications/PixelPaint/Tools/ZoomTool.cpp @@ -26,7 +26,7 @@ void ZoomTool::on_mousedown(Layer*, MouseEvent& event) ErrorOr ZoomTool::get_properties_widget() { if (!m_properties_widget) { - auto properties_widget = TRY(GUI::Widget::try_create()); + auto properties_widget = GUI::Widget::construct(); properties_widget->set_layout(); auto sensitivity_container = TRY(properties_widget->try_add()); diff --git a/Userland/Applications/SpaceAnalyzer/main.cpp b/Userland/Applications/SpaceAnalyzer/main.cpp index 9c7d490e26..ad068ca17d 100644 --- a/Userland/Applications/SpaceAnalyzer/main.cpp +++ b/Userland/Applications/SpaceAnalyzer/main.cpp @@ -134,7 +134,7 @@ ErrorOr serenity_main(Main::Arguments arguments) } }); - auto context_menu = TRY(GUI::Menu::try_create()); + auto context_menu = GUI::Menu::construct(); context_menu->add_action(open_action); context_menu->add_action(copy_path_action); context_menu->add_action(delete_action); diff --git a/Userland/Applications/SystemMonitor/NetworkStatisticsWidget.cpp b/Userland/Applications/SystemMonitor/NetworkStatisticsWidget.cpp index 1cb42123e9..bb42d61450 100644 --- a/Userland/Applications/SystemMonitor/NetworkStatisticsWidget.cpp +++ b/Userland/Applications/SystemMonitor/NetworkStatisticsWidget.cpp @@ -71,7 +71,7 @@ NetworkStatisticsWidget::NetworkStatisticsWidget() net_adapters_fields.empend("bytes_out", "Bytes Out"_string, Gfx::TextAlignment::CenterRight); m_adapter_model = GUI::JsonArrayModel::create("/sys/kernel/net/adapters", move(net_adapters_fields)); m_adapter_table_view->set_model(MUST(GUI::SortingProxyModel::create(*m_adapter_model))); - m_adapter_context_menu = MUST(GUI::Menu::try_create()); + m_adapter_context_menu = GUI::Menu::construct(); m_adapter_context_menu->add_action(GUI::Action::create( "Open in Network Settings...", MUST(Gfx::Bitmap::load_from_file("/res/icons/16x16/network.png"sv)), [this](GUI::Action&) { m_adapter_table_view->selection().for_each_index([this](GUI::ModelIndex const& index) { diff --git a/Userland/Applications/SystemMonitor/main.cpp b/Userland/Applications/SystemMonitor/main.cpp index 57a1cca2ea..35519b3a0e 100644 --- a/Userland/Applications/SystemMonitor/main.cpp +++ b/Userland/Applications/SystemMonitor/main.cpp @@ -432,7 +432,7 @@ ErrorOr serenity_main(Main::Arguments arguments) GUI::Application::the()->quit(); })); - auto process_context_menu = TRY(GUI::Menu::try_create()); + auto process_context_menu = GUI::Menu::construct(); process_context_menu->add_action(kill_action); process_context_menu->add_action(stop_action); process_context_menu->add_action(continue_action); diff --git a/Userland/Applications/ThemeEditor/MainWidget.cpp b/Userland/Applications/ThemeEditor/MainWidget.cpp index 6548c6ba80..39770d42b5 100644 --- a/Userland/Applications/ThemeEditor/MainWidget.cpp +++ b/Userland/Applications/ThemeEditor/MainWidget.cpp @@ -464,7 +464,7 @@ ErrorOr MainWidget::add_property_tab(PropertyTab const& property_tab) auto& scrollable_container = m_property_tabs->add_tab(TRY(String::from_utf8(property_tab.title))); scrollable_container.set_should_hide_unnecessary_scrollbars(true); - auto properties_list = TRY(GUI::Widget::try_create()); + auto properties_list = GUI::Widget::construct(); scrollable_container.set_widget(properties_list); properties_list->set_layout(GUI::Margins { 8 }, 12); diff --git a/Userland/Demos/CatDog/main.cpp b/Userland/Demos/CatDog/main.cpp index 81750f7c09..1871de47d2 100644 --- a/Userland/Demos/CatDog/main.cpp +++ b/Userland/Demos/CatDog/main.cpp @@ -44,7 +44,7 @@ ErrorOr serenity_main(Main::Arguments arguments) window->set_main_widget(catdog_widget); catdog_widget->set_layout(GUI::Margins {}, 0); - auto context_menu = TRY(GUI::Menu::try_create()); + auto context_menu = GUI::Menu::construct(); context_menu->add_action(GUI::CommonActions::make_about_action("CatDog Demo"_string, app_icon, window)); context_menu->add_separator(); context_menu->add_action(GUI::CommonActions::make_quit_action([&](auto&) { app->quit(); })); diff --git a/Userland/Demos/WidgetGallery/GalleryWidget.cpp b/Userland/Demos/WidgetGallery/GalleryWidget.cpp index 4acf3fea41..dc19983d6f 100644 --- a/Userland/Demos/WidgetGallery/GalleryWidget.cpp +++ b/Userland/Demos/WidgetGallery/GalleryWidget.cpp @@ -89,7 +89,7 @@ GalleryWidget::GalleryWidget() m_font_button->set_icon(Gfx::Bitmap::load_from_file("/res/icons/16x16/app-font-editor.png"sv).release_value_but_fixme_should_propagate_errors()); m_font_button->on_click = [&](auto) { - auto picker = GUI::FontPicker::try_create(window(), &m_text_editor->font(), false).release_value_but_fixme_should_propagate_errors(); + auto picker = GUI::FontPicker::construct(window(), &m_text_editor->font(), false); if (picker->exec() == GUI::Dialog::ExecResult::OK) { m_text_editor->set_font(picker->font()); } diff --git a/Userland/DevTools/HackStudio/GMLPreviewWidget.cpp b/Userland/DevTools/HackStudio/GMLPreviewWidget.cpp index 0628e49dcb..5198a05e2e 100644 --- a/Userland/DevTools/HackStudio/GMLPreviewWidget.cpp +++ b/Userland/DevTools/HackStudio/GMLPreviewWidget.cpp @@ -29,7 +29,7 @@ void GMLPreviewWidget::load_gml(DeprecatedString const& gml) // FIXME: Parsing errors happen while the user is typing. What should we do about them? (void)load_from_gml(gml, [](StringView name) -> ErrorOr> { - return GUI::Label::try_create(TRY(String::formatted("{} is not registered as a GML element!", name))); + return GUI::Label::construct(TRY(String::formatted("{} is not registered as a GML element!", name))); }); if (children().is_empty()) { diff --git a/Userland/DevTools/Profiler/main.cpp b/Userland/DevTools/Profiler/main.cpp index 0f960d7ee8..c775748ac2 100644 --- a/Userland/DevTools/Profiler/main.cpp +++ b/Userland/DevTools/Profiler/main.cpp @@ -92,7 +92,7 @@ ErrorOr serenity_main(Main::Arguments arguments) main_widget->set_fill_with_background_color(true); main_widget->set_layout(); - auto timeline_header_container = TRY(GUI::Widget::try_create()); + auto timeline_header_container = GUI::Widget::construct(); timeline_header_container->set_layout(); timeline_header_container->set_fill_with_background_color(true); timeline_header_container->set_shrink_to_fit(true); diff --git a/Userland/Games/BrickGame/main.cpp b/Userland/Games/BrickGame/main.cpp index d39120e063..8a4ae9e49e 100644 --- a/Userland/Games/BrickGame/main.cpp +++ b/Userland/Games/BrickGame/main.cpp @@ -60,10 +60,10 @@ ErrorOr serenity_main(Main::Arguments arguments) game->toggle_pause(); })); - auto show_shadow_piece_action = TRY(GUI::Action::try_create_checkable("Show Shadow Piece", GUI::Shortcut {}, [&](auto& action) { + auto show_shadow_piece_action = GUI::Action::create_checkable("Show Shadow Piece", GUI::Shortcut {}, [&](auto& action) { game->set_show_shadow_hint(action.is_checked()); Config::write_bool(app_name, app_name, "ShowShadowPiece"sv, action.is_checked()); - })); + }); game->set_show_shadow_hint(Config::read_bool(app_name, app_name, "ShowShadowPiece"sv, true)); show_shadow_piece_action->set_checked(game->show_shadow_hint()); diff --git a/Userland/Games/Snake/main.cpp b/Userland/Games/Snake/main.cpp index d86b8d7111..f54c0dbae7 100644 --- a/Userland/Games/Snake/main.cpp +++ b/Userland/Games/Snake/main.cpp @@ -127,11 +127,11 @@ ErrorOr serenity_main(Main::Arguments arguments) skin_menu->set_icon(app_icon.bitmap_for_size(16)); auto add_skin_action = [&](StringView name, bool enable_color) -> ErrorOr { - auto action = TRY(GUI::Action::try_create_checkable(name, {}, [&, enable_color](auto& action) { + auto action = GUI::Action::create_checkable(name, GUI::Shortcut {}, [&, enable_color](auto& action) { Config::write_string("Snake"sv, "Snake"sv, "SnakeSkin"sv, action.text()); game.set_skin_name(String::from_deprecated_string(action.text()).release_value_but_fixme_should_propagate_errors()); change_snake_color->set_enabled(enable_color); - })); + }); skin_action_group.add_action(*action); if (snake_skin_name == name) diff --git a/Userland/Libraries/LibGUI/FilePicker.cpp b/Userland/Libraries/LibGUI/FilePicker.cpp index 5073625007..0556b365c1 100644 --- a/Userland/Libraries/LibGUI/FilePicker.cpp +++ b/Userland/Libraries/LibGUI/FilePicker.cpp @@ -38,7 +38,7 @@ namespace GUI { ErrorOr> FilePicker::get_filepath(Badge, i32 window_server_client_id, i32 parent_window_id, Mode mode, StringView window_title, StringView file_basename, StringView path, Optional> allowed_file_types) { - auto picker = TRY(FilePicker::try_create(nullptr, mode, file_basename, path, ScreenPosition::DoNotPosition, move(allowed_file_types))); + auto picker = FilePicker::construct(nullptr, mode, file_basename, path, ScreenPosition::DoNotPosition, move(allowed_file_types)); auto parent_rect = ConnectionToWindowServer::the().get_window_rect_from_client(window_server_client_id, parent_window_id); picker->center_within(parent_rect); picker->constrain_to_desktop(); diff --git a/Userland/Libraries/LibGUI/LinkLabel.cpp b/Userland/Libraries/LibGUI/LinkLabel.cpp index 78db8e710b..cb10c5a378 100644 --- a/Userland/Libraries/LibGUI/LinkLabel.cpp +++ b/Userland/Libraries/LibGUI/LinkLabel.cpp @@ -23,7 +23,7 @@ ErrorOr> LinkLabel::try_create(String text) { auto label = TRY(adopt_nonnull_ref_or_enomem(new (nothrow) LinkLabel(move(text)))); TRY(label->create_actions()); - TRY(label->create_menus()); + label->create_menus(); return label; } @@ -47,13 +47,12 @@ ErrorOr LinkLabel::create_actions() return {}; } -ErrorOr LinkLabel::create_menus() +void LinkLabel::create_menus() { - m_context_menu = TRY(Menu::try_create()); + m_context_menu = Menu::construct(); m_context_menu->add_action(*m_open_action); m_context_menu->add_separator(); m_context_menu->add_action(*m_copy_action); - return {}; } void LinkLabel::set_hovered(bool hover) diff --git a/Userland/Libraries/LibGUI/LinkLabel.h b/Userland/Libraries/LibGUI/LinkLabel.h index 80196c9f93..b36b58f69b 100644 --- a/Userland/Libraries/LibGUI/LinkLabel.h +++ b/Userland/Libraries/LibGUI/LinkLabel.h @@ -22,7 +22,7 @@ private: explicit LinkLabel(String text = {}); ErrorOr create_actions(); - ErrorOr create_menus(); + void create_menus(); virtual void mousemove_event(MouseEvent&) override; virtual void mousedown_event(MouseEvent&) override; diff --git a/Userland/Libraries/LibGUI/PathBreadcrumbbar.cpp b/Userland/Libraries/LibGUI/PathBreadcrumbbar.cpp index 2fb1a9c6d0..371f49bf1c 100644 --- a/Userland/Libraries/LibGUI/PathBreadcrumbbar.cpp +++ b/Userland/Libraries/LibGUI/PathBreadcrumbbar.cpp @@ -23,8 +23,8 @@ namespace GUI { ErrorOr> PathBreadcrumbbar::try_create() { - auto location_text_box = TRY(TextBox::try_create()); - auto breadcrumbbar = TRY(Breadcrumbbar::try_create()); + auto location_text_box = TextBox::construct(); + auto breadcrumbbar = Breadcrumbbar::construct(); auto path_breadcrumbbar = TRY(adopt_nonnull_ref_or_enomem(new (nothrow) PathBreadcrumbbar(*location_text_box, *breadcrumbbar))); path_breadcrumbbar->set_layout(); diff --git a/Userland/Libraries/LibGUI/Toolbar.cpp b/Userland/Libraries/LibGUI/Toolbar.cpp index 0608540a48..fc53c8e87b 100644 --- a/Userland/Libraries/LibGUI/Toolbar.cpp +++ b/Userland/Libraries/LibGUI/Toolbar.cpp @@ -221,7 +221,7 @@ ErrorOr Toolbar::update_overflow_menu() m_overflow_action->set_enabled(true); m_overflow_button->set_visible(true); - m_overflow_menu = TRY(Menu::try_create()); + m_overflow_menu = Menu::construct(); m_overflow_button->set_menu(m_overflow_menu); for (size_t i = marginal_index.value(); i < m_items.size(); ++i) { diff --git a/Userland/Services/Taskbar/main.cpp b/Userland/Services/Taskbar/main.cpp index a355c7eb75..32518d586b 100644 --- a/Userland/Services/Taskbar/main.cpp +++ b/Userland/Services/Taskbar/main.cpp @@ -117,7 +117,7 @@ ErrorOr> discover_apps_and_categories() ErrorOr> build_system_menu(GUI::Window& window) { Vector const sorted_app_categories = TRY(discover_apps_and_categories()); - auto system_menu = TRY(GUI::Menu::try_create("\xE2\x9A\xA1"_string)); // HIGH VOLTAGE SIGN + auto system_menu = GUI::Menu::construct("\xE2\x9A\xA1"_string); // HIGH VOLTAGE SIGN system_menu->add_action(GUI::Action::create("&About SerenityOS", TRY(Gfx::Bitmap::load_from_file("/res/icons/16x16/ladyball.png"sv)), [&](auto&) { GUI::Process::spawn_or_show_error(&window, "/bin/About"sv); diff --git a/Userland/Utilities/notify.cpp b/Userland/Utilities/notify.cpp index 5f8fb6a276..a84d80cea9 100644 --- a/Userland/Utilities/notify.cpp +++ b/Userland/Utilities/notify.cpp @@ -23,7 +23,7 @@ ErrorOr serenity_main(Main::Arguments arguments) args_parser.add_positional_argument(icon_path, "Path of icon to display in the notification", "icon-path", Core::ArgsParser::Required::No); args_parser.parse(arguments); - auto notification = TRY(GUI::Notification::try_create()); + auto notification = GUI::Notification::construct(); notification->set_text(message); notification->set_title(title); if (!icon_path.is_empty()) {