RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-14 20:04:59 +00:00
Code Issues Activity Actions

Ext2FS: Writing to a slow symlink should not treat it like a fast one

Browse source 
We would misinterpret short writes to the first 60 bytes of a slow
symlink as writes to a fast symlink.
This commit is contained in:
Andreas Kling 2019-11-17 19:12:29 +01:00
parent 5d08665d9a
commit a712d4ac0c
1 changed files with 2 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Kernel/FileSystem/Ext2FileSystem.cpp
View file

@ -722,13 +722,12 @@ ssize_t Ext2FSInode::write_bytes(off_t offset, ssize_t count, const u8* data, Fi
Locker fs_locker(fs().m_lock);
if (is_symlink()) {
// FIXME: This doesn't seem right if the inode is already bigger than 'max_inline_symlink_length'
if ((offset + count) < max_inline_symlink_length) {
if (max((size_t)(offset + count), (size_t)m_raw_inode.i_size) < max_inline_symlink_length) {
#ifdef EXT2_DEBUG
dbgprintf("Ext2FSInode: write_bytes poking into i_block array for inline symlink '%s' (%u bytes)\n", String((const char*)data, count).characters(), count);
#endif
memcpy(((u8*)m_raw_inode.i_block) + offset, data, (size_t)count);
if ((offset + count) > (off_t)m_raw_inode.i_size)
if ((size_t)(offset + count) > (size_t)m_raw_inode.i_size)
m_raw_inode.i_size = offset + count;
set_metadata_dirty(true);
return count;