RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 21:47:46 +00:00
Code Issues Activity Actions

LibJS: Update Temporal RoundDuration AO to some spec changes

Browse source 
This commit effectively just does a bulk update of this function to the
spec. Since there have been so many spec changes, no specific change was
made in mind, and many FIXMEs have been left for where we are still out
of date.

These changes also appear to include a normative change to the temporal
spec which was previously resulting in timeouts for some tests, and is
now resulting in a timeout.

Furthermore, this also resolves some crashes by protecting against
division by zero, instead throwing a RangeError. This can only happen
when a custom calender is provided which returns funky values. See:

https://github.com/tc39/proposal-temporal/commit/ed85e9

Diff Tests:
    +8 ✅    -4 💀    -4 💥️
This commit is contained in:
Shannon Booth 2024-01-05 13:28:39 +13:00 • committed by Andrew Kaster
parent 83b84cf0bd
commit a7316d3641
4 changed files with 283 additions and 273 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibJS/Runtime/Temporal/Duration.h
View file

@ -107,7 +107,7 @@ struct MoveRelativeDateResult {
// Used by RoundDuration to temporarily hold values
struct RoundedDuration {
DurationRecord duration_record;
double remainder;
double total;
};
// Table 8: Duration Record Fields, https://tc39.es/proposal-temporal/#table-temporal-duration-record-fields