RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 07:47:37 +00:00
Code Issues Activity Actions

LibGUI: Use default instead of an empty constructor/destructor

Browse source 
Default implementations allow for more optimizations.
See: https://pvs-studio.com/en/docs/warnings/v832/
This commit is contained in:
Brian Gianforcaro 2021-09-15 23:57:01 -07:00 • committed by Andreas Kling
parent 4fe99ff0d6
commit a7364eef3c
4 changed files with 5 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibGUI/Margins.h
View file

@ -10,7 +10,7 @@ namespace GUI {
class Margins { class Margins {
public: public:
Margins() { } Margins() = default;
Margins(int all) Margins(int all)
: m_top(all) : m_top(all)
, m_right(all) , m_right(all)
@ -39,7 +39,7 @@ public:
, m_left(left) , m_left(left)
{ {
} }
~Margins() { } ~Margins() = default;
bool is_null() const { return !m_left && !m_top && !m_right && !m_bottom; } bool is_null() const { return !m_left && !m_top && !m_right && !m_bottom; }

2
Userland/Libraries/LibGUI/ModelIndex.h
View file

@ -17,7 +17,7 @@ class ModelIndex {
friend class Model; friend class Model;
public: public:
ModelIndex() { } ModelIndex() = default;
bool is_valid() const { return m_model && m_row != -1 && m_column != -1; } bool is_valid() const { return m_model && m_row != -1 && m_column != -1; }
int row() const { return m_row; } int row() const { return m_row; }

2
Userland/Libraries/LibGUI/Shortcut.h
View file

@ -13,7 +13,7 @@ namespace GUI {
class Shortcut { class Shortcut {
public: public:
Shortcut() { } Shortcut() = default;
Shortcut(u8 modifiers, KeyCode key) Shortcut(u8 modifiers, KeyCode key)
: m_modifiers(modifiers) : m_modifiers(modifiers)
, m_key(key) , m_key(key)

2
Userland/Libraries/LibGUI/TextPosition.h
View file

@ -12,7 +12,7 @@ namespace GUI {
class TextPosition { class TextPosition {
public: public:
TextPosition() { } TextPosition() = default;
TextPosition(size_t line, size_t column) TextPosition(size_t line, size_t column)
: m_line(line) : m_line(line)
, m_column(column) , m_column(column)