RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-10 06:27:35 +00:00
Code Issues Activity Actions

PDFViewer: Prevent infinity recursion

Browse source 
When removing all contents from the NumericInput box in PDFViewer the
callback set the (empty) text again back in the box, triggering another
callback in a recursive, non-stopping fashion. Not setting the text back
in the box avoids the problem.
This commit is contained in:
Rodrigo Tobar 2022-11-22 23:08:56 +08:00 • committed by Andreas Kling
parent bc7da24fe6
commit a740423e23
1 changed files with 0 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

1
Userland/Applications/PDFViewer/NumericInput.cpp
View file

@ -29,7 +29,6 @@ NumericInput::NumericInput()
auto new_number_opt = builder.to_string().to_int(); auto new_number_opt = builder.to_string().to_int();
if (!new_number_opt.has_value()) { if (!new_number_opt.has_value()) {
m_needs_text_reset = true; m_needs_text_reset = true;
set_text(builder.to_string());
return; return;
} else { } else {
m_needs_text_reset = false; m_needs_text_reset = false;