RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 08:57:34 +00:00
Code Issues Activity Actions

HackStudio: Fix crash when opening or creating with open empty file

Browse source 
This commit fixes a crash that would occur due to an unnamed file being
automatically saved via EditorWrapper::save(). Now, we throw up a
FilePicker::get_save_filepath.
This commit is contained in:
Skye Sprung 2022-08-29 18:25:35 +02:00 • committed by Linus Groh
parent fa2ece1183
commit a7b7003376
1 changed files with 8 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Userland/DevTools/HackStudio/EditorWrapper.cpp
View file

@ -10,6 +10,7 @@
#include "HackStudio.h" #include "HackStudio.h"
#include <LibGUI/Application.h> #include <LibGUI/Application.h>
#include <LibGUI/BoxLayout.h> #include <LibGUI/BoxLayout.h>
#include <LibGUI/FilePicker.h>
#include <LibGUI/Label.h> #include <LibGUI/Label.h>
#include <LibGfx/Font/Font.h> #include <LibGfx/Font/Font.h>
#include <LibGfx/Font/FontDatabase.h> #include <LibGfx/Font/FontDatabase.h>
@ -72,6 +73,13 @@ void EditorWrapper::set_filename(String const& filename)
void EditorWrapper::save() void EditorWrapper::save()
{ {
if (filename().is_empty()) {
auto file_picker_action = GUI::CommonActions::make_save_as_action([&](auto&) {
Optional<String> save_path = GUI::FilePicker::get_save_filepath(window(), "file"sv, "txt"sv, project_root().value());
set_filename(save_path.value());
});
file_picker_action->activate();
}
editor().write_to_file(filename()); editor().write_to_file(filename());
update_diff(); update_diff();
editor().update(); editor().update();