RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-06-28 21:22:08 +00:00
Code Issues Activity Actions

LibJS: Store bytecode instruction length in instruction itself

Browse source 
Instead of running a big switch statement on the opcode when checking
how long an instruction is, we now simply store that in a member
variable at construction time for instant access.

This yields a 10.2% speed-up on Kraken/ai-astar :^)
This commit is contained in:
Andreas Kling 2023-09-13 21:32:51 +02:00
parent d7c1cc0276
commit a7c1af08ca
2 changed files with 90 additions and 104 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Libraries/LibJS/Bytecode/Instruction.h
View file

@ -134,7 +134,7 @@ public:
bool is_terminator() const;
Type type() const { return m_type; }
size_t length() const;
size_t length() const { return m_length; }
DeprecatedString to_deprecated_string(Bytecode::Executable const&) const;
ThrowCompletionOr<void> execute(Bytecode::Interpreter&) const;
static void destroy(Instruction&);
@ -144,14 +144,16 @@ public:
SourceRecord source_record() const { return m_source_record; }
protected:
explicit Instruction(Type type)
Instruction(Type type, size_t length)
: m_type(type)
, m_length(length)
{
}
private:
SourceRecord m_source_record {};
Type m_type {};
size_t m_length {};
};
class InstructionStreamIterator {