RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 20:07:36 +00:00
Code Issues Activity Actions

AK: Make StringImpl a bit smaller.

Browse source 
There's no need for a member char* m_characters if we always store them
in the inline buffer. So with this patch, we now do.
After that, rearrange the members a bit for ideal packing. :^)
This commit is contained in:
Andreas Kling 2019-06-20 13:21:56 +02:00
parent 8c0ae711d8
commit a7dc1a7d6b
2 changed files with 30 additions and 31 deletions
Download patch file Download diff file Expand all files Collapse all files

23
AK/StringImpl.h
View file

@ -14,9 +14,9 @@ enum ShouldChomp {
class StringImpl : public Retainable<StringImpl> {
public:
static Retained<StringImpl> create_uninitialized(ssize_t length, char*& buffer);
static Retained<StringImpl> create_uninitialized(int length, char*& buffer);
static RetainPtr<StringImpl> create(const char* cstring, ShouldChomp = NoChomp);
static RetainPtr<StringImpl> create(const char* cstring, ssize_t length, ShouldChomp = NoChomp);
static RetainPtr<StringImpl> create(const char* cstring, int length, ShouldChomp = NoChomp);
Retained<StringImpl> to_lowercase() const;
Retained<StringImpl> to_uppercase() const;
@ -29,17 +29,17 @@ public:
~StringImpl();
ssize_t length() const { return m_length; }
const char* characters() const { return m_characters; }
char operator[](ssize_t i) const
int length() const { return m_length; }
const char* characters() const { return &m_inline_buffer[0]; }
char operator[](int i) const
{
ASSERT(i >= 0 && i < m_length);
return m_characters[i];
return characters()[i];
}
unsigned hash() const
{
if (!m_hasHash)
if (!m_has_hash)
compute_hash();
return m_hash;
}
@ -49,21 +49,20 @@ private:
ConstructTheEmptyStringImpl
};
explicit StringImpl(ConstructTheEmptyStringImplTag)
: m_characters("")
{
m_inline_buffer[0] = '\0';
}
enum ConstructWithInlineBufferTag {
ConstructWithInlineBuffer
};
StringImpl(ConstructWithInlineBufferTag, ssize_t length);
StringImpl(ConstructWithInlineBufferTag, int length);
void compute_hash() const;
ssize_t m_length { 0 };
mutable bool m_hasHash { false };
const char* m_characters { nullptr };
int m_length { 0 };
mutable unsigned m_hash { 0 };
mutable bool m_has_hash { false };
char m_inline_buffer[0];
};