RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 15:07:45 +00:00
Code Issues Activity Actions

Base: Remove unnecessary UID separation of multi-process Browser

Browse source 
After looking closely at this, I realized that we've been running
all the service processes under separate user accounts even though
there's actually no need to.

Since we already use pledge() and unveil() to limit the scope and
access of these programs, separating them to another UID doesn't
achieve anything meaningful. So let's bring them back to the "anon"
user account and simplify things.

Programs affected:

- ImageDecoder
- RequestServer
- WebContent
- WebSocket

Longer term, I'd like for all of these to get spawned for the current
desktop user somehow, possibly by some kind of session manager, or
perhaps by the Browser program itself. But for now they remain under
SystemServer's control.
This commit is contained in:
Andreas Kling 2021-05-06 12:54:01 +02:00
parent 434c190667
commit a7e44d8b3c
3 changed files with 5 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Base/etc/SystemServer.ini
View file

@ -3,7 +3,7 @@ Socket=/tmp/portal/request
SocketPermissions=660
Lazy=1
Priority=low
User=request
User=anon
BootModes=text,graphical,self-test
MultiInstance=1
AcceptSocketConnections=1
@ -12,7 +12,7 @@ AcceptSocketConnections=1
Socket=/tmp/portal/webcontent
SocketPermissions=660
Lazy=1
User=webcontent
User=anon
BootModes=graphical
MultiInstance=1
AcceptSocketConnections=1
@ -21,7 +21,7 @@ AcceptSocketConnections=1
Socket=/tmp/portal/image
SocketPermissions=660
Lazy=1
User=image
User=anon
BootModes=graphical
MultiInstance=1
AcceptSocketConnections=1
@ -37,7 +37,7 @@ Socket=/tmp/portal/websocket
SocketPermissions=660
Lazy=1
Priority=low
User=websocket
User=anon
BootModes=text,graphical,self-test
MultiInstance=1
AcceptSocketConnections=1