RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-20 16:45:07 +00:00
Code Issues Activity Actions

Kernel: Remove unused WaitQueue::should_block(bool)

Browse source 
Nothing ever changed the state of WaitQueue::m_should_block, so this
removes the variable entirely.
This commit is contained in:
Andreas Kling 2021-08-23 01:28:12 +02:00
parent e51a5e2d5d
commit a82b5e6e50
2 changed files with 2 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Kernel/WaitQueue.cpp
View file

@ -15,9 +15,9 @@ bool WaitQueue::should_add_blocker(Thread::Blocker& b, void* data)
VERIFY(data != nullptr); // Thread that is requesting to be blocked VERIFY(data != nullptr); // Thread that is requesting to be blocked
VERIFY(m_lock.is_locked()); VERIFY(m_lock.is_locked());
VERIFY(b.blocker_type() == Thread::Blocker::Type::Queue); VERIFY(b.blocker_type() == Thread::Blocker::Type::Queue);
if (m_wake_requested || !m_should_block) { if (m_wake_requested) {
m_wake_requested = false; m_wake_requested = false;
dbgln_if(WAITQUEUE_DEBUG, "WaitQueue @ {}: do not block thread {}, {}", this, data, m_should_block ? "wake was pending" : "not blocking"); dbgln_if(WAITQUEUE_DEBUG, "WaitQueue @ {}: do not block thread {}", this, data);
return false; return false;
} }
dbgln_if(WAITQUEUE_DEBUG, "WaitQueue @ {}: should block thread {}", this, data); dbgln_if(WAITQUEUE_DEBUG, "WaitQueue @ {}: should block thread {}", this, data);

7
Kernel/WaitQueue.h
View file

@ -18,12 +18,6 @@ public:
u32 wake_n(u32 wake_count); u32 wake_n(u32 wake_count);
u32 wake_all(); u32 wake_all();
void should_block(bool block)
{
SpinlockLocker lock(m_lock);
m_should_block = block;
}
template<class... Args> template<class... Args>
Thread::BlockResult wait_on(const Thread::BlockTimeout& timeout, Args&&... args) Thread::BlockResult wait_on(const Thread::BlockTimeout& timeout, Args&&... args)
{ {
@ -41,7 +35,6 @@ protected:
private: private:
bool m_wake_requested { false }; bool m_wake_requested { false };
bool m_should_block { true };
}; };
} }