From a85223e13be469bfdda0126b9e107bf6eb93bb33 Mon Sep 17 00:00:00 2001 From: Lucas CHOLLET Date: Tue, 7 Jun 2022 16:07:02 +0200 Subject: [PATCH] LibGUI: Add a default virtual destructor to virtual classes Affected classes are children of TextDocumentUndoCommand: - InsertTextCommand - RemoveTextCommand - ReplaceAllTextCommand --- Userland/Libraries/LibGUI/TextDocument.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Userland/Libraries/LibGUI/TextDocument.h b/Userland/Libraries/LibGUI/TextDocument.h index 0af3140d31..371c20176e 100644 --- a/Userland/Libraries/LibGUI/TextDocument.h +++ b/Userland/Libraries/LibGUI/TextDocument.h @@ -215,6 +215,7 @@ protected: class InsertTextCommand : public TextDocumentUndoCommand { public: InsertTextCommand(TextDocument&, String const&, TextPosition const&); + virtual ~InsertTextCommand() = default; virtual void perform_formatting(TextDocument::Client const&) override; virtual void undo() override; virtual void redo() override; @@ -231,6 +232,7 @@ private: class RemoveTextCommand : public TextDocumentUndoCommand { public: RemoveTextCommand(TextDocument&, String const&, TextRange const&); + virtual ~RemoveTextCommand() = default; virtual void undo() override; virtual void redo() override; TextRange const& range() const { return m_range; } @@ -246,6 +248,7 @@ class ReplaceAllTextCommand final : public GUI::TextDocumentUndoCommand { public: ReplaceAllTextCommand(GUI::TextDocument& document, String const& text, GUI::TextRange const& range, String const& action_text); + virtual ~ReplaceAllTextCommand() = default; void redo() override; void undo() override; bool merge_with(GUI::Command const&) override;