RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 06:27:45 +00:00
Code Issues Activity Actions

CI: Require a blank line between commit titles and bodies

Browse source
This commit is contained in:
Idan Horowitz 2022-01-11 23:31:08 +02:00
parent 14f6856d1d
commit a8537ad096
2 changed files with 8 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

4
.github/workflows/lintcommits.yml vendored
View file

@ -20,6 +20,10 @@ jobs:
pattern: /^[^\r]*$/, pattern: /^[^\r]*$/,
error: "Commit message contains CRLF line breaks (only unix-style LF linebreaks are allowed)", error: "Commit message contains CRLF line breaks (only unix-style LF linebreaks are allowed)",
}, },
{
pattern: /^.+(\r?\n(\r?\n.*)*)?$/,
error: "Empty line between commit title and body is missing",
},
{ {
pattern: /^.{0,72}(?:\r?\n(?:(.{0,72})|(.*?([a-z]+:\/\/)?(([a-zA-Z0-9_]|-)+\.)+[a-z]{2,}(:\d+)?([a-zA-Z_0-9@:%\+.~\?&/=]|-)+).*?))*$/, pattern: /^.{0,72}(?:\r?\n(?:(.{0,72})|(.*?([a-z]+:\/\/)?(([a-zA-Z0-9_]|-)+\.)+[a-z]{2,}(:\d+)?([a-zA-Z_0-9@:%\+.~\?&/=]|-)+).*?))*$/,
error: "Commit message lines are too long (maximum allowed is 72 characters, except for URLs)", error: "Commit message lines are too long (maximum allowed is 72 characters, except for URLs)",

4
Meta/lint-commit.sh
View file

@ -30,6 +30,10 @@ while read -r line; do
((line_number += 1)) ((line_number += 1))
line_length=${#line} line_length=${#line}
if [[ $line_number -eq 2 ]] && [[ $line_length -ne 0 ]]; then
error "Empty line between commit title and body is missing"
fi
category_pattern="^\S.*?\S: .+" category_pattern="^\S.*?\S: .+"
if [[ $line_number -eq 1 ]] && (echo "$line" | grep -E -v -q "$category_pattern"); then if [[ $line_number -eq 1 ]] && (echo "$line" | grep -E -v -q "$category_pattern"); then
error "Missing category in commit title (if this is a fix up of a previous commit, it should be squashed)" error "Missing category in commit title (if this is a fix up of a previous commit, it should be squashed)"