From a8655fbf52dd5170c7b162b964480bf859a4e905 Mon Sep 17 00:00:00 2001 From: Jelle Raaijmakers Date: Thu, 20 Jan 2022 02:20:42 +0100 Subject: [PATCH] LibGL+LibSoftGPU: Clean up some `for` loops --- Userland/Libraries/LibGL/SoftwareGLContext.cpp | 9 +++------ Userland/Libraries/LibSoftGPU/Device.cpp | 4 ++-- 2 files changed, 5 insertions(+), 8 deletions(-) diff --git a/Userland/Libraries/LibGL/SoftwareGLContext.cpp b/Userland/Libraries/LibGL/SoftwareGLContext.cpp index 8e75476e38..a07ff21600 100644 --- a/Userland/Libraries/LibGL/SoftwareGLContext.cpp +++ b/Userland/Libraries/LibGL/SoftwareGLContext.cpp @@ -1980,14 +1980,12 @@ void SoftwareGLContext::get_floating_point(GLenum pname, T* params) *params = parameter.value.boolean_value ? GL_TRUE : GL_FALSE; break; case GL_DOUBLE: - for (size_t i = 0; i < parameter.count; ++i) { + for (size_t i = 0; i < parameter.count; ++i) params[i] = parameter.value.double_list[i]; - } break; case GL_INT: - for (size_t i = 0; i < parameter.count; ++i) { + for (size_t i = 0; i < parameter.count; ++i) params[i] = parameter.value.integer_list[i]; - } break; default: VERIFY_NOT_REACHED(); @@ -2015,9 +2013,8 @@ void SoftwareGLContext::gl_get_integerv(GLenum pname, GLint* data) break; } case GL_INT: - for (size_t i = 0; i < parameter.count; ++i) { + for (size_t i = 0; i < parameter.count; ++i) data[i] = parameter.value.integer_list[i]; - } break; default: VERIFY_NOT_REACHED(); diff --git a/Userland/Libraries/LibSoftGPU/Device.cpp b/Userland/Libraries/LibSoftGPU/Device.cpp index 444a3d365f..7309a94969 100644 --- a/Userland/Libraries/LibSoftGPU/Device.cpp +++ b/Userland/Libraries/LibSoftGPU/Device.cpp @@ -733,8 +733,8 @@ void Device::draw_primitives(PrimitiveType primitive_type, FloatMatrix4x4 const& Triangle triangle; triangle.vertices[0] = vertices.at(0); // Root vertex is always the vertex defined first - for (size_t i = 1; i < vertices.size() - 1; i++) // This is technically `n-2` triangles. We start at index 1 - { + // This is technically `n-2` triangles. We start at index 1 + for (size_t i = 1; i < vertices.size() - 1; i++) { triangle.vertices[1] = vertices.at(i); triangle.vertices[2] = vertices.at(i + 1); m_triangle_list.append(triangle);