RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 13:37:45 +00:00
Code Issues Activity Actions

LibJS: Rename DurationFormat's DurationSign to DurationRecordSign

Browse source 
This is an editorial change in the Intl.DurationFormat proposal. See:
f947239
This commit is contained in:
Timothy Flynn 2022-08-30 11:21:38 -04:00 • committed by Tim Flynn
parent f8c51fec1d
commit a86b840c64
2 changed files with 5 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Userland/Libraries/LibJS/Runtime/Intl/DurationFormat.cpp
View file

@ -177,8 +177,8 @@ ThrowCompletionOr<Temporal::DurationRecord> to_duration_record(VM& vm, Value inp
return result;
}
// 1.1.4 DurationSign ( record ), https://tc39.es/proposal-intl-duration-format/#sec-durationsign
i8 duration_sign(Temporal::DurationRecord const& record)
// 1.1.4 DurationRecordSign ( record ), https://tc39.es/proposal-intl-duration-format/#sec-durationrecordsign
i8 duration_record_sign(Temporal::DurationRecord const& record)
{
// 1. For each row in Table 1, except the header row, in table order, do
for (auto const& duration_instances_component : duration_instances_components) {
@ -204,8 +204,8 @@ i8 duration_sign(Temporal::DurationRecord const& record)
// 1.1.5 IsValidDurationRecord ( record ), https://tc39.es/proposal-intl-duration-format/#sec-isvaliddurationrecord
bool is_valid_duration_record(Temporal::DurationRecord const& record)
{
// 1. Let sign be ! DurationSign(record).
auto sign = duration_sign(record);
// 1. Let sign be ! DurationRecordSign(record).
auto sign = duration_record_sign(record);
// 2. For each row in Table 1, except the header row, in table order, do
for (auto const& duration_instances_component : duration_instances_components) {

2
Userland/Libraries/LibJS/Runtime/Intl/DurationFormat.h
View file

@ -221,7 +221,7 @@ struct DurationUnitOptions {
};
ThrowCompletionOr<Temporal::DurationRecord> to_duration_record(VM&, Value input);
i8 duration_sign(Temporal::DurationRecord const&);
i8 duration_record_sign(Temporal::DurationRecord const&);
bool is_valid_duration_record(Temporal::DurationRecord const&);
ThrowCompletionOr<DurationUnitOptions> get_duration_unit_options(VM&, String const& unit, Object const& options, StringView base_style, Span<StringView const> styles_list, StringView digital_base, StringView previous_style);
Vector<PatternPartition> partition_duration_format_pattern(VM&, DurationFormat const&, Temporal::DurationRecord const& duration);