RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 16:57:35 +00:00
Code Issues Activity Actions

FileManager+FileOperation: Report Errors when doing an file operation

Browse source 
Report back errors from the FileOperation to the FileManager and
display them in the MessageBox
This commit is contained in:
Tobias Christiansen 2021-04-14 20:15:28 +02:00 • committed by Andreas Kling
parent 7d60164d93
commit a8915ecd61
3 changed files with 35 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

17
Userland/Applications/FileManager/FileOperationProgressWidget.cpp
View file

@ -63,12 +63,23 @@ FileOperationProgressWidget::FileOperationProgressWidget(NonnullRefPtr<Core::Fil
m_notifier->on_ready_to_read = [this] {
auto line = m_helper_pipe->read_line();
if (line.is_null()) {
did_error();
did_error("Read from pipe returned null.");
return;
}
auto parts = line.split_view(' ');
VERIFY(!parts.is_empty());
if (parts[0] == "ERROR"sv) {
did_error(line.substring(6));
return;
}
if (parts[0] == "WARN"sv) {
did_error(line.substring(5));
return;
}
if (parts[0] == "FINISH"sv) {
did_finish();
return;
@ -101,11 +112,11 @@ void FileOperationProgressWidget::did_finish()
window()->close();
}
void FileOperationProgressWidget::did_error()
void FileOperationProgressWidget::did_error(const String message)
{
// FIXME: Communicate more with the user about errors.
close_pipe();
GUI::MessageBox::show(window(), "An error occurred", "Error", GUI::MessageBox::Type::Error, GUI::MessageBox::InputType::OK);
GUI::MessageBox::show(window(), String::formatted("An error occurred: {}", message), "Error", GUI::MessageBox::Type::Error, GUI::MessageBox::InputType::OK);
window()->close();
}