RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 16:37:47 +00:00
Code Issues Activity Actions

LibJS: Port Symbol to String

Browse source 
This includes the VM's global_symbol_registry HashMap, which can now
store String keys.
This commit is contained in:
Linus Groh 2023-02-11 16:14:41 +00:00
parent 5e72fde954
commit a8bf2f8e4c
11 changed files with 27 additions and 27 deletions
Download patch file Download diff file Expand all files Collapse all files

13
Userland/Libraries/LibJS/Runtime/Symbol.h
View file

@ -7,8 +7,7 @@
#pragma once
#include <AK/DeprecatedString.h>
#include <AK/StringView.h>
#include <AK/String.h>
#include <LibJS/Heap/Cell.h>
namespace JS {
@ -17,19 +16,19 @@ class Symbol final : public Cell {
JS_CELL(Symbol, Cell);
public:
[[nodiscard]] static NonnullGCPtr<Symbol> create(VM&, Optional<DeprecatedString> description, bool is_global);
[[nodiscard]] static NonnullGCPtr<Symbol> create(VM&, Optional<String> description, bool is_global);
virtual ~Symbol() = default;
Optional<DeprecatedString> const& description() const { return m_description; }
Optional<String> const& description() const { return m_description; }
bool is_global() const { return m_is_global; }
DeprecatedString descriptive_string() const;
ErrorOr<String> descriptive_string() const;
private:
Symbol(Optional<DeprecatedString>, bool);
Symbol(Optional<String>, bool);
Optional<DeprecatedString> m_description;
Optional<String> m_description;
bool m_is_global;
};