RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 00:27:35 +00:00
Code Issues Activity Actions

LibWeb: Convert WebAssemblyObject functions to ThrowCompletionOr

Browse source
This commit is contained in:
Idan Horowitz 2021-10-31 16:55:06 +02:00
parent 3e8c76d5ab
commit a8d39bc070
2 changed files with 9 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

12
Userland/Libraries/LibWeb/WebAssembly/WebAssemblyObject.cpp
View file

@ -35,9 +35,9 @@ void WebAssemblyObject::initialize(JS::GlobalObject& global_object)
Object::initialize(global_object); Object::initialize(global_object);
u8 attr = JS::Attribute::Configurable | JS::Attribute::Writable | JS::Attribute::Enumerable; u8 attr = JS::Attribute::Configurable | JS::Attribute::Writable | JS::Attribute::Enumerable;
define_old_native_function("validate", validate, 1, attr); define_native_function("validate", validate, 1, attr);
define_old_native_function("compile", compile, 1, attr); define_native_function("compile", compile, 1, attr);
define_old_native_function("instantiate", instantiate, 1, attr); define_native_function("instantiate", instantiate, 1, attr);
auto& vm = global_object.vm(); auto& vm = global_object.vm();
@ -87,7 +87,7 @@ void WebAssemblyObject::visit_edges(Visitor& visitor)
} }
} }
JS_DEFINE_OLD_NATIVE_FUNCTION(WebAssemblyObject::validate) JS_DEFINE_NATIVE_FUNCTION(WebAssemblyObject::validate)
{ {
// FIXME: Implement this once module validation is implemented in LibWasm. // FIXME: Implement this once module validation is implemented in LibWasm.
dbgln("Hit WebAssemblyObject::validate() stub!"); dbgln("Hit WebAssemblyObject::validate() stub!");
@ -127,7 +127,7 @@ JS::ThrowCompletionOr<size_t> parse_module(JS::GlobalObject& global_object, JS::
return WebAssemblyObject::s_compiled_modules.size() - 1; return WebAssemblyObject::s_compiled_modules.size() - 1;
} }
JS_DEFINE_OLD_NATIVE_FUNCTION(WebAssemblyObject::compile) JS_DEFINE_NATIVE_FUNCTION(WebAssemblyObject::compile)
{ {
// FIXME: This shouldn't block! // FIXME: This shouldn't block!
auto buffer_or_error = vm.argument(0).to_object(global_object); auto buffer_or_error = vm.argument(0).to_object(global_object);
@ -291,7 +291,7 @@ JS::ThrowCompletionOr<size_t> WebAssemblyObject::instantiate_module(Wasm::Module
return s_instantiated_modules.size() - 1; return s_instantiated_modules.size() - 1;
} }
JS_DEFINE_OLD_NATIVE_FUNCTION(WebAssemblyObject::instantiate) JS_DEFINE_NATIVE_FUNCTION(WebAssemblyObject::instantiate)
{ {
// FIXME: This shouldn't block! // FIXME: This shouldn't block!
auto buffer_or_error = vm.argument(0).to_object(global_object); auto buffer_or_error = vm.argument(0).to_object(global_object);

6
Userland/Libraries/LibWeb/WebAssembly/WebAssemblyObject.h
View file

@ -60,9 +60,9 @@ public:
static Wasm::AbstractMachine s_abstract_machine; static Wasm::AbstractMachine s_abstract_machine;
private: private:
JS_DECLARE_OLD_NATIVE_FUNCTION(validate); JS_DECLARE_NATIVE_FUNCTION(validate);
JS_DECLARE_OLD_NATIVE_FUNCTION(compile); JS_DECLARE_NATIVE_FUNCTION(compile);
JS_DECLARE_OLD_NATIVE_FUNCTION(instantiate); JS_DECLARE_NATIVE_FUNCTION(instantiate);
}; };
class WebAssemblyMemoryObject final : public JS::Object { class WebAssemblyMemoryObject final : public JS::Object {