From a9162b7e98e9378d01f423ba638c5d37fd276323 Mon Sep 17 00:00:00 2001 From: Linus Groh Date: Wed, 4 Aug 2021 23:02:52 +0100 Subject: [PATCH] LibJS: Implement Temporal.ZonedDateTime.prototype.epochMilliseconds --- .../Temporal/ZonedDateTimePrototype.cpp | 20 +++++++++++++++++++ .../Runtime/Temporal/ZonedDateTimePrototype.h | 1 + ...nedDateTime.prototype.epochMilliseconds.js | 15 ++++++++++++++ 3 files changed, 36 insertions(+) create mode 100644 Userland/Libraries/LibJS/Tests/builtins/Temporal/ZonedDateTime/ZonedDateTime.prototype.epochMilliseconds.js diff --git a/Userland/Libraries/LibJS/Runtime/Temporal/ZonedDateTimePrototype.cpp b/Userland/Libraries/LibJS/Runtime/Temporal/ZonedDateTimePrototype.cpp index cbcfb9772b..946a8dfb97 100644 --- a/Userland/Libraries/LibJS/Runtime/Temporal/ZonedDateTimePrototype.cpp +++ b/Userland/Libraries/LibJS/Runtime/Temporal/ZonedDateTimePrototype.cpp @@ -43,6 +43,7 @@ void ZonedDateTimePrototype::initialize(GlobalObject& global_object) define_native_accessor(vm.names.microsecond, microsecond_getter, {}, Attribute::Configurable); define_native_accessor(vm.names.nanosecond, nanosecond_getter, {}, Attribute::Configurable); define_native_accessor(vm.names.epochSeconds, epoch_seconds_getter, {}, Attribute::Configurable); + define_native_accessor(vm.names.epochMilliseconds, epoch_milliseconds_getter, {}, Attribute::Configurable); } static ZonedDateTime* typed_this(GlobalObject& global_object) @@ -373,4 +374,23 @@ JS_DEFINE_NATIVE_FUNCTION(ZonedDateTimePrototype::epoch_seconds_getter) return Value((double)s.to_base(10).to_int().value()); } +// 6.3.16 get Temporal.ZonedDateTime.prototype.epochMilliseconds, https://tc39.es/proposal-temporal/#sec-get-temporal.zoneddatetime.prototype.epochmilliseconds +JS_DEFINE_NATIVE_FUNCTION(ZonedDateTimePrototype::epoch_milliseconds_getter) +{ + // 1. Let zonedDateTime be the this value. + // 2. Perform ? RequireInternalSlot(zonedDateTime, [[InitializedTemporalZonedDateTime]]). + auto* zoned_date_time = typed_this(global_object); + if (vm.exception()) + return {}; + + // 3. Let ns be zonedDateTime.[[Nanoseconds]]. + auto& ns = zoned_date_time->nanoseconds(); + + // 4. Let ms be RoundTowardsZero(ℝ(ns) / 10^6). + auto ms = ns.big_integer().divided_by(Crypto::UnsignedBigInteger { 1'000'000 }).quotient; + + // 5. Return 𝔽(ms). + return Value((double)ms.to_base(10).to_int().value()); +} + } diff --git a/Userland/Libraries/LibJS/Runtime/Temporal/ZonedDateTimePrototype.h b/Userland/Libraries/LibJS/Runtime/Temporal/ZonedDateTimePrototype.h index c1725dd900..ecd640a874 100644 --- a/Userland/Libraries/LibJS/Runtime/Temporal/ZonedDateTimePrototype.h +++ b/Userland/Libraries/LibJS/Runtime/Temporal/ZonedDateTimePrototype.h @@ -32,6 +32,7 @@ private: JS_DECLARE_NATIVE_FUNCTION(microsecond_getter); JS_DECLARE_NATIVE_FUNCTION(nanosecond_getter); JS_DECLARE_NATIVE_FUNCTION(epoch_seconds_getter); + JS_DECLARE_NATIVE_FUNCTION(epoch_milliseconds_getter); }; } diff --git a/Userland/Libraries/LibJS/Tests/builtins/Temporal/ZonedDateTime/ZonedDateTime.prototype.epochMilliseconds.js b/Userland/Libraries/LibJS/Tests/builtins/Temporal/ZonedDateTime/ZonedDateTime.prototype.epochMilliseconds.js new file mode 100644 index 0000000000..d30669522e --- /dev/null +++ b/Userland/Libraries/LibJS/Tests/builtins/Temporal/ZonedDateTime/ZonedDateTime.prototype.epochMilliseconds.js @@ -0,0 +1,15 @@ +describe("correct behavior", () => { + test("basic functionality", () => { + const timeZone = new Temporal.TimeZone("UTC"); + const zonedDateTime = new Temporal.ZonedDateTime(1625614921000000000n, timeZone); + expect(zonedDateTime.epochMilliseconds).toBe(1625614921000); + }); +}); + +test("errors", () => { + test("this value must be a Temporal.ZonedDateTime object", () => { + expect(() => { + Reflect.get(Temporal.ZonedDateTime.prototype, "epochMilliseconds", "foo"); + }).toThrowWithMessage(TypeError, "Not a Temporal.ZonedDateTime"); + }); +});