RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 16:27:35 +00:00
Code Issues Activity Actions

Ladybird/Qt: Rename new_tab(StringView) to new_tab_from_content

Browse source 
Having an overload of new_tab with StringView and QString that each do
very different things is uncomfortable, to say the least.
This commit is contained in:
Andrew Kaster 2024-01-30 18:52:59 -07:00 • committed by Tim Flynn
parent 48ce8fb4e9
commit a91680dd55
3 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Ladybird/Qt/BrowserWindow.h
View file

@ -74,7 +74,7 @@ public slots:
void tab_title_changed(int index, QString const&);
void tab_favicon_changed(int index, QIcon const& icon);
Tab& new_tab(QString const&, Web::HTML::ActivateTab);
Tab& new_tab(StringView html, Web::HTML::ActivateTab);
Tab& new_tab_from_content(StringView html, Web::HTML::ActivateTab);
void activate_tab(int index);
void close_tab(int index);
void close_current_tab();