RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 05:28:11 +00:00
Code Issues Activity Actions

Kernel/FileSystem: Remove FIXME about old/new path being the same

Browse source 
Added comment after confirming that Linux and OpenBSD implenment the
same behavior.
This commit is contained in:
Taj Morton 2022-12-30 22:44:45 -08:00 • committed by Sam Atkins
parent d57e9b53a0
commit a91fc697bb
1 changed files with 5 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Kernel/FileSystem/VirtualFileSystem.cpp
View file

@ -648,7 +648,11 @@ ErrorOr<void> VirtualFileSystem::rename(Credentials const& credentials, Custody&
if (!new_custody_or_error.is_error()) { if (!new_custody_or_error.is_error()) {
auto& new_custody = *new_custody_or_error.value(); auto& new_custody = *new_custody_or_error.value();
auto& new_inode = new_custody.inode(); auto& new_inode = new_custody.inode();
// FIXME: Is this really correct? Check what other systems do. // When the source/dest inodes are the same (in other words,
// when `old_path` and `new_path` are the same), perform a no-op
// and return success.
// Linux (`vfs_rename()`) and OpenBSD (`dorenameat()`) appear to have
// this same no-op behavior.
if (&new_inode == &old_inode) if (&new_inode == &old_inode)
return {}; return {};
if (new_parent_inode.metadata().is_sticky()) { if (new_parent_inode.metadata().is_sticky()) {