RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 23:17:45 +00:00
Code Issues Activity Actions

Revert "LibPDF: Don't over-read in charset formats 1 and 2"

Browse source 
This reverts commit 52afa936c4.

No longer necessary after #23122 -- turns out things work
better when you do them right.

No behavior change.
This commit is contained in:
Nico Weber 2024-02-08 18:46:01 -05:00 • committed by Sam Atkins
parent 76d1536307
commit a91fecb17e
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibPDF/Fonts/CFF.cpp
View file

@ -756,7 +756,7 @@ PDFErrorOr<Vector<CFF::SID>> CFF::parse_charset(Reader&& reader, size_t glyph_co
// CFF spec, "Table 19 Range1 Format (Charset)"
auto first_sid = TRY(reader.try_read<BigEndian<SID>>());
int left = TRY(reader.try_read<Card8>());
for (SID sid = first_sid; left >= 0 && names.size() < glyph_count - 1; left--, sid++)
for (SID sid = first_sid; left >= 0; left--, sid++)
TRY(names.try_append(sid));
}
} else if (format == 2) {
@ -767,7 +767,7 @@ PDFErrorOr<Vector<CFF::SID>> CFF::parse_charset(Reader&& reader, size_t glyph_co
// CFF spec, "Table 21 Range2 Format"
auto first_sid = TRY(reader.try_read<BigEndian<SID>>());
int left = TRY(reader.try_read<BigEndian<Card16>>());
for (SID sid = first_sid; left >= 0 && names.size() < glyph_count - 1; left--, sid++)
for (SID sid = first_sid; left >= 0; left--, sid++)
TRY(names.try_append(sid));
}
} else {