RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 12:38:12 +00:00
Code Issues Activity Actions

LibJS: Ensure function declarations don't leak outside function scopes

Browse source 
When using VM::set_variable() to put the created ScriptFunction onto a
ScopeObject, we would previously unexpectedly reach the global object as
set_variable() checks each traversed scope for an existing Variable with
the given name - which would cause a leak of the inner function past the
outer function (we even had a test expecting that behaviour!). Now we
first declare functions (as DeclarationKind::Var) before setting them.
This will need some more work to make hoisting across non-lexical scopes
work, but it fixes this specific issue for now.

Fixes #6766.
This commit is contained in:
Linus Groh 2021-05-13 23:58:45 +01:00
parent b221cad659
commit a92dc4e30d
3 changed files with 31 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

12
Userland/Libraries/LibJS/Tests/if-statement-function-declaration.js
View file

@ -2,8 +2,8 @@ describe("function declarations in if statement clauses", () => {
test("if clause", () => {
if (true) function foo() {}
if (false) function bar() {}
expect(typeof globalThis.foo).toBe("function");
expect(typeof globalThis.bar).toBe("undefined");
expect(typeof foo).toBe("function");
expect(typeof bar).toBe("undefined");
});
test("else clause", () => {
@ -11,15 +11,15 @@ describe("function declarations in if statement clauses", () => {
else function foo() {}
if (true);
else function bar() {}
expect(typeof globalThis.foo).toBe("function");
expect(typeof globalThis.bar).toBe("undefined");
expect(typeof foo).toBe("function");
expect(typeof bar).toBe("undefined");
});
test("if and else clause", () => {
if (true) function foo() {}
else function bar() {}
expect(typeof globalThis.foo).toBe("function");
expect(typeof globalThis.bar).toBe("undefined");
expect(typeof foo).toBe("function");
expect(typeof bar).toBe("undefined");
});
test("syntax error in strict mode", () => {