RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 07:27:45 +00:00
Code Issues Activity Actions

LibGfx: Commonize functions in P*MLoader class implementations

Browse source 
Problem:
- Functions are duplicated in [PBM,PGM,PPM]Loader class
  implementations. They are functionally equivalent. This does not
  follow the DRY (Don't Repeat Yourself) principle.

Solution:
- Factor out the common functions into a separate file.
- Refactor common code to generic functions.
- Change `PPM_DEBUG` macro to be `PORTABLE_IMAGE_LOADER_DEBUG` to work
  with all the supported types. This requires adding the image type to
  the debug log messages for easier debugging.
This commit is contained in:
Lenny Maiorani 2020-12-20 10:19:03 -07:00 • committed by Andreas Kling
parent 6fac1abac4
commit a95d230a3e
6 changed files with 367 additions and 685 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Libraries/LibGfx/Color.h
View file

@ -101,19 +101,19 @@ public:
m_value |= value << 24;
}
void set_red(u8 value)
constexpr void set_red(u8 value)
{
m_value &= 0xff00ffff;
m_value |= value << 16;
}
void set_green(u8 value)
constexpr void set_green(u8 value)
{
m_value &= 0xffff00ff;
m_value |= value << 8;
}
void set_blue(u8 value)
constexpr void set_blue(u8 value)
{
m_value &= 0xffffff00;
m_value |= value;