RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 19:57:45 +00:00
Code Issues Activity Actions

Everywhere: Make global inline functions not static

Browse source 
`inline` already assigns vague linkage, so there's no need to
also assign per-TU linkage. Allows the linker to dedup these
functions across TUs (and is almost always just the Right Thing
to do in C++ -- this ain't C).
This commit is contained in:
Nico Weber 2023-01-04 12:25:47 -05:00 • committed by Linus Groh
parent 0a3cc10bb6
commit a96f307af1
3 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Kernel/Process.h
View file

@ -1012,7 +1012,7 @@ inline ProcessID Thread::pid() const
#define VERIFY_NO_PROCESS_BIG_LOCK(process) \ #define VERIFY_NO_PROCESS_BIG_LOCK(process) \
VERIFY(!process->big_lock().is_exclusively_locked_by_current_thread()) VERIFY(!process->big_lock().is_exclusively_locked_by_current_thread())
inline static ErrorOr<NonnullOwnPtr<KString>> try_copy_kstring_from_user(Kernel::Syscall::StringArgument const& string) inline ErrorOr<NonnullOwnPtr<KString>> try_copy_kstring_from_user(Kernel::Syscall::StringArgument const& string)
{ {
Userspace<char const*> characters((FlatPtr)string.characters); Userspace<char const*> characters((FlatPtr)string.characters);
return try_copy_kstring_from_user(characters, string.length); return try_copy_kstring_from_user(characters, string.length);

2
Userland/Libraries/LibGfx/FillPathImplementation.h
View file

@ -14,7 +14,7 @@
namespace Gfx::Detail { namespace Gfx::Detail {
[[maybe_unused]] inline static void approximately_place_on_int_grid(FloatPoint ffrom, FloatPoint fto, IntPoint& from, IntPoint& to, Optional<IntPoint> previous_to) [[maybe_unused]] inline void approximately_place_on_int_grid(FloatPoint ffrom, FloatPoint fto, IntPoint& from, IntPoint& to, Optional<IntPoint> previous_to)
{ {
auto diffs = fto - ffrom; auto diffs = fto - ffrom;
// Truncate all first (round down). // Truncate all first (round down).

2
Userland/Utilities/touch.cpp
View file

@ -31,7 +31,7 @@ template<typename... Parameters>
exit(1); exit(1);
} }
inline static bool validate_timestamp(unsigned year, unsigned month, unsigned day, unsigned hour, unsigned minute, unsigned second) inline bool validate_timestamp(unsigned year, unsigned month, unsigned day, unsigned hour, unsigned minute, unsigned second)
{ {
return (year >= 1970) && (month >= 1 && month <= 12) && (day >= 1 && day <= static_cast<unsigned>(days_in_month(year, month))) && (hour <= 23) && (minute <= 59) && (second <= 59); return (year >= 1970) && (month >= 1 && month <= 12) && (day >= 1 && day <= static_cast<unsigned>(days_in_month(year, month))) && (hour <= 23) && (minute <= 59) && (second <= 59);
} }