RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 08:47:44 +00:00
Code Issues Activity Actions

LibGfx: Nudge points away from the start point in radial gradients

Browse source 
Avoids a division by zero, and an incorrect pixel in some repeating
radial gradient cases.

(Ref tests updated)
This commit is contained in:
MacDue 2023-08-22 22:29:43 +01:00 • committed by Andreas Kling
parent df58fa8653
commit a98201f889
4 changed files with 3 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Libraries/LibGfx/GradientPainting.cpp
View file

@ -523,9 +523,9 @@ static auto create_radial_gradient_between_two_circles(Gfx::FloatPoint start_cen
[=](float x, float y) {
auto loc = [&] {
FloatPoint point { x, y };
auto dist = point.distance_from(start_point);
if (dist == 0)
return 0.0f;
// Add a little to avoid division by zero at the focal point.
if (point == start_point)
point += FloatPoint { 0.001f, 0.001f };
// The "vec" (unit) vector points from the focal point to the current point.
auto dist = point.distance_from(start_point);
auto vec = (point - start_point) / dist;