RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-30 21:48:11 +00:00
Code Issues Activity Actions

LibGUI: Resolve use-after-free error

Browse source 
Objects taken by reference are no longer valid when used in
`deferred_invoke`. Explicitly copying them solve the issue.
This commit is contained in:
Lucas CHOLLET 2023-03-21 21:57:08 -04:00 • committed by Andreas Kling
parent 2a410f8985
commit a9cc61224d
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibGUI/FileSystemModel.cpp
View file

@ -729,7 +729,7 @@ bool FileSystemModel::fetch_thumbnail_for(Node const& node)
auto const on_error = [path, update_progress](Error error) -> void { auto const on_error = [path, update_progress](Error error) -> void {
// Note: We need to defer that to avoid the function removing its last reference // Note: We need to defer that to avoid the function removing its last reference
// i.e. trying to destroy itself, which is prohibited. // i.e. trying to destroy itself, which is prohibited.
Core::EventLoop::current().deferred_invoke([&] { Core::EventLoop::current().deferred_invoke([path, error = Error::copy(error)]() mutable {
s_thumbnail_cache.with_locked([path, error = move(error)](auto& cache) { s_thumbnail_cache.with_locked([path, error = move(error)](auto& cache) {
if (error != Error::from_errno(ECANCELED)) { if (error != Error::from_errno(ECANCELED)) {
cache.thumbnail_cache.set(path, nullptr); cache.thumbnail_cache.set(path, nullptr);