RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 15:57:35 +00:00
Code Issues Activity Actions

LibJS+LibWeb: Explicitly mark ignored members in visit_edges methods

Browse source
This commit is contained in:
Matthew Olsson 2023-03-22 17:05:16 -07:00 • committed by Andreas Kling
parent 39d8c8d2a9
commit a9d192e882
4 changed files with 13 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

7
Userland/Libraries/LibJS/Heap/Cell.h
View file

@ -80,6 +80,13 @@ public:
visit_impl(value.as_cell());
}
// Allow explicitly ignoring a GC-allocated member in a visit_edges implementation instead
// of just not using it.
template<typename T>
void ignore(T const&)
{
}
protected:
virtual void visit_impl(Cell&) = 0;
virtual ~Visitor() = default;

1
Userland/Libraries/LibJS/Runtime/Shape.cpp
View file

@ -123,6 +123,7 @@ void Shape::visit_edges(Cell::Visitor& visitor)
for (auto& it : *m_property_table)
it.key.visit_edges(visitor);
}
visitor.ignore(m_prototype_transitions);
}
Optional<PropertyMetadata> Shape::lookup(StringOrSymbol const& property_key) const