RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 06:17:35 +00:00
Code Issues Activity Actions

LibRegex: Don't return empty vectors from RegexStringView::lines()

Browse source 
Instead, return a vector of one empty string.
This commit is contained in:
Ali Mohammad Pur 2022-01-25 00:21:06 +03:30 • committed by Ali Mohammad Pur
parent c9d026d7bc
commit aa20210119
1 changed files with 9 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

9
Userland/Libraries/LibRegex/RegexMatch.h
View file

@ -172,6 +172,9 @@ public:
return new_views; return new_views;
}, },
[](Utf32View view) { [](Utf32View view) {
if (view.is_empty())
return Vector<RegexStringView> { view };
Vector<RegexStringView> views; Vector<RegexStringView> views;
u32 newline = '\n'; u32 newline = '\n';
while (!view.is_empty()) { while (!view.is_empty()) {
@ -187,6 +190,9 @@ public:
return views; return views;
}, },
[](Utf16View view) { [](Utf16View view) {
if (view.is_empty())
return Vector<RegexStringView> { view };
Vector<RegexStringView> views; Vector<RegexStringView> views;
u16 newline = '\n'; u16 newline = '\n';
while (!view.is_empty()) { while (!view.is_empty()) {
@ -202,6 +208,9 @@ public:
return views; return views;
}, },
[](Utf8View const& view) { [](Utf8View const& view) {
if (view.is_empty())
return Vector<RegexStringView> { view };
Vector<RegexStringView> views; Vector<RegexStringView> views;
auto it = view.begin(); auto it = view.begin();
auto previous_newline_position_it = it; auto previous_newline_position_it = it;