From aa381c4a677ba2504ad06587b9978bc03d1ffead Mon Sep 17 00:00:00 2001 From: Andreas Kling Date: Tue, 8 Mar 2022 16:32:29 +0100 Subject: [PATCH] Kernel: Mark sys$fchmod() as not needing the big lock This syscall doesn't access any data that was implicitly protected by the big lock. --- Kernel/API/Syscall.h | 2 +- Kernel/Syscalls/chmod.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Kernel/API/Syscall.h b/Kernel/API/Syscall.h index 7bba964468..27492b2f48 100644 --- a/Kernel/API/Syscall.h +++ b/Kernel/API/Syscall.h @@ -68,7 +68,7 @@ enum class NeedsBigProcessLock { S(exit, NeedsBigProcessLock::Yes) \ S(exit_thread, NeedsBigProcessLock::Yes) \ S(fchdir, NeedsBigProcessLock::No) \ - S(fchmod, NeedsBigProcessLock::Yes) \ + S(fchmod, NeedsBigProcessLock::No) \ S(fchown, NeedsBigProcessLock::Yes) \ S(fcntl, NeedsBigProcessLock::Yes) \ S(fork, NeedsBigProcessLock::Yes) \ diff --git a/Kernel/Syscalls/chmod.cpp b/Kernel/Syscalls/chmod.cpp index ac86e262bc..8219d34301 100644 --- a/Kernel/Syscalls/chmod.cpp +++ b/Kernel/Syscalls/chmod.cpp @@ -34,7 +34,7 @@ ErrorOr Process::sys$chmod(Userspace u ErrorOr Process::sys$fchmod(int fd, mode_t mode) { - VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this); + VERIFY_NO_PROCESS_BIG_LOCK(this); TRY(require_promise(Pledge::fattr)); auto description = TRY(open_file_description(fd)); TRY(description->chmod(mode));