RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 06:17:35 +00:00
Code Issues Activity Actions

LibLine: Use more descriptive names for row/column

Browse source 
The names x and y caused confusion because of their typical use as
horiz/vert.
This commit is contained in:
AnotherTest 2020-06-08 00:48:40 +04:30 • committed by Andreas Kling
parent 9b17bf3dcd
commit aa3e440a58
4 changed files with 40 additions and 40 deletions
Download patch file Download diff file Expand all files Collapse all files

12
Libraries/LibLine/Editor.h
View file

@ -264,11 +264,11 @@ private:
set_origin(position[0], position[1]);
}
void set_origin(int x, int y)
void set_origin(int row, int col)
{
m_origin_x = x;
m_origin_y = y;
m_suggestion_display->set_origin(x, y, {});
m_origin_row = row;
m_origin_column = col;
m_suggestion_display->set_origin(row, col, {});
}
bool should_break_token(Vector<u32, 1024>& buffer, size_t index);
@ -312,8 +312,8 @@ private:
bool m_cached_prompt_valid { false };
// Exact position before our prompt in the terminal.
size_t m_origin_x { 0 };
size_t m_origin_y { 0 };
size_t m_origin_row { 0 };
size_t m_origin_column { 0 };
OwnPtr<SuggestionDisplay> m_suggestion_display;