mirror of
https://github.com/RGBCube/serenity
synced 2025-07-25 20:07:35 +00:00
AK+Kernel+LibELF: Remove the need for IteratorDecision::Continue
By constraining two implementations, the compiler will select the best fitting one. All this will require is duplicating the implementation and simplifying for the `void` case. This constraining also informs both the caller and compiler by passing the callback parameter types as part of the constraint (e.g.: `IterationFunction<int>`). Some `for_each` functions in LibELF only take functions which return `void`. This is a minimal correctness check, as it removes one way for a function to incompletely do something. There seems to be a possible idiom where inside a lambda, a `return;` is the same as `continue;` in a for-loop.
This commit is contained in:
parent
bbaa463032
commit
aa4d41fe2c
25 changed files with 311 additions and 127 deletions
|
@ -97,7 +97,6 @@ void Image::dump() const
|
|||
dbgln(" offset: {:x}", program_header.offset());
|
||||
dbgln(" flags: {:x}", program_header.flags());
|
||||
dbgln(" }}");
|
||||
return IterationDecision::Continue;
|
||||
});
|
||||
|
||||
for (unsigned i = 0; i < header().e_shnum; ++i) {
|
||||
|
@ -344,7 +343,6 @@ NEVER_INLINE void Image::sort_symbols() const
|
|||
m_sorted_symbols.ensure_capacity(symbol_count());
|
||||
for_each_symbol([this](const auto& symbol) {
|
||||
m_sorted_symbols.append({ symbol.value(), symbol.name(), {}, symbol });
|
||||
return IterationDecision::Continue;
|
||||
});
|
||||
quick_sort(m_sorted_symbols, [](auto& a, auto& b) {
|
||||
return a.address < b.address;
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue