RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 14:27:35 +00:00
Code Issues Activity Actions

Help+LibManual: Make the children accessor fallible

Browse source 
This is convenient for the section node which might compute children
on the fly.
This commit is contained in:
kleines Filmröllchen 2022-12-14 13:33:28 +01:00 • committed by Andrew Kaster
parent 437d3ca0ea
commit aa5e574872
5 changed files with 22 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibManual/Node.h
View file

@ -20,7 +20,7 @@ class Node : public RefCounted<Node> {
public:
virtual ~Node() = default;
virtual NonnullRefPtrVector<Node>& children() const = 0;
virtual ErrorOr<Span<NonnullRefPtr<Node>>> children() const = 0;
virtual Node const* parent() const = 0;
virtual ErrorOr<String> name() const = 0;
virtual bool is_page() const { return false; }

4
Userland/Libraries/LibManual/PageNode.cpp
View file

@ -16,10 +16,10 @@ Node const* PageNode::parent() const
return m_section.ptr();
}
NonnullRefPtrVector<Node>& PageNode::children() const
ErrorOr<Span<NonnullRefPtr<Node>>> PageNode::children() const
{
static NonnullRefPtrVector<Node> empty_vector;
return empty_vector;
return empty_vector.span();
}
ErrorOr<String> PageNode::path() const

2
Userland/Libraries/LibManual/PageNode.h
View file

@ -23,7 +23,7 @@ public:
{
}
virtual NonnullRefPtrVector<Node>& children() const override;
virtual ErrorOr<Span<NonnullRefPtr<Node>>> children() const override;
virtual Node const* parent() const override;
virtual ErrorOr<String> name() const override { return m_page; };
virtual bool is_page() const override { return true; }

6
Userland/Libraries/LibManual/SectionNode.h
View file

@ -23,10 +23,10 @@ public:
{
}
virtual NonnullRefPtrVector<Node>& children() const override
virtual ErrorOr<Span<NonnullRefPtr<Node>>> children() const override
{
MUST(reify_if_needed());
return m_children;
TRY(reify_if_needed());
return m_children.span();
}
virtual Node const* parent() const override { return nullptr; }