RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-16 19:45:07 +00:00
Code Issues Activity Actions

Kernel: Use get_syscall_path_argument() in sys$execve()

Browse source 
Paths passed to sys$execve() should certainly be subject to all the
usual path validation checks.
This commit is contained in:
Andreas Kling 2020-01-18 11:43:28 +01:00
parent 545e2ba065
commit aa63de53bd
1 changed files with 7 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

13
Kernel/Process.cpp
View file

@ -1114,12 +1114,13 @@ int Process::sys$execve(const Syscall::SC_execve_params* user_params)
if (params.arguments.length > ARG_MAX || params.environment.length > ARG_MAX)
return -E2BIG;
auto path = validate_and_copy_string_from_user(params.path);
if (path.is_null())
return -EFAULT;
if (path.is_empty())
return -ENOENT;
String path;
{
auto path_arg = get_syscall_path_argument(params.path);
if (path_arg.is_error())
return path_arg.error();
path = path_arg.value();
}
auto copy_user_strings = [&](const auto& list, auto& output) {
if (!list.length)