RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 04:17:34 +00:00
Code Issues Activity Actions

LibGUI: Fix off-by-one in Scrollbar::scrubber_rect()

Browse source 
Recent changes in the button painting code made this unnecessary. For
the case of value() == max(), the scrubber button would overlap the
increment button.

Fixes #6838.
This commit is contained in:
Linus Groh 2021-05-03 22:22:53 +01:00
parent 0c1d1d97d5
commit aa70a56174
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibGUI/Scrollbar.cpp
View file

@ -150,7 +150,7 @@ Gfx::IntRect Scrollbar::scrubber_rect() const
if (value() == min()) if (value() == min())
x_or_y = button_size(); x_or_y = button_size();
else if (value() == max()) else if (value() == max())
x_or_y = (length(orientation()) - button_size() - visible_scrubber_size()) + 1; x_or_y = length(orientation()) - button_size() - visible_scrubber_size();
else { else {
float range_size = max() - min(); float range_size = max() - min();
float available = scrubbable_range_in_pixels(); float available = scrubbable_range_in_pixels();