RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 06:17:35 +00:00
Code Issues Activity Actions

Kernel: Use unchecked_append in PerformanceEventBuffer raw_backtrace()

Browse source 
We always validate the size before we append, so there is
no reason to use the checked append.
This commit is contained in:
Brian Gianforcaro 2022-01-03 03:33:47 -08:00 • committed by Andreas Kling
parent 1a2aad287f
commit aa77c2ca58
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Kernel/PerformanceEventBuffer.cpp
View file

@ -38,7 +38,7 @@ static Vector<FlatPtr, PerformanceEvent::max_stack_frame_count> raw_backtrace(Fl
{ {
Vector<FlatPtr, PerformanceEvent::max_stack_frame_count> backtrace; Vector<FlatPtr, PerformanceEvent::max_stack_frame_count> backtrace;
if (ip != 0) if (ip != 0)
backtrace.append(ip); backtrace.unchecked_append(ip);
FlatPtr stack_ptr_copy; FlatPtr stack_ptr_copy;
FlatPtr stack_ptr = bp; FlatPtr stack_ptr = bp;
// FIXME: Figure out how to remove this SmapDisabler without breaking profile stacks. // FIXME: Figure out how to remove this SmapDisabler without breaking profile stacks.
@ -63,7 +63,7 @@ static Vector<FlatPtr, PerformanceEvent::max_stack_frame_count> raw_backtrace(Fl
break; break;
if (retaddr == 0) if (retaddr == 0)
break; break;
backtrace.append(retaddr); backtrace.unchecked_append(retaddr);
if (backtrace.size() == PerformanceEvent::max_stack_frame_count) if (backtrace.size() == PerformanceEvent::max_stack_frame_count)
break; break;
stack_ptr = stack_ptr_copy; stack_ptr = stack_ptr_copy;