From aaa81cd3b99235017e392e583b8af7956e20e4af Mon Sep 17 00:00:00 2001 From: Idan Horowitz Date: Fri, 3 Nov 2023 20:44:05 +0200 Subject: [PATCH] Revert "LibJS/JIT: Clear exception before executing finalizer" This reverts commit 0daebef727ee0b60ab68f887049720f0fbbbdbb9. Finally blocks do not unconditionally swallow pending exceptions. This resolves #21759 and fixes the 2 remaining failing test-js tests. --- Userland/Libraries/LibJS/JIT/Compiler.cpp | 1 - 1 file changed, 1 deletion(-) diff --git a/Userland/Libraries/LibJS/JIT/Compiler.cpp b/Userland/Libraries/LibJS/JIT/Compiler.cpp index d55215f5d4..a824eeb34f 100644 --- a/Userland/Libraries/LibJS/JIT/Compiler.cpp +++ b/Userland/Libraries/LibJS/JIT/Compiler.cpp @@ -426,7 +426,6 @@ void Compiler::check_exception() m_assembler.jump(label_for(*handler)); no_exception.link(m_assembler); } else if (auto const* finalizer = current_block().finalizer(); finalizer) { - store_vm_register(Bytecode::Register::exception(), GPR1); m_assembler.jump_if(Assembler::Operand::Register(GPR0), Assembler::Condition::NotEqualTo, Assembler::Operand::Register(GPR1),